From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ye Zhang <ye.zhang@rock-chips.com>,
Linus Walleij <linus.walleij@linaro.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
tao.huang@rock-chips.com
Subject: Re: [PATCH v3 6/7] dt-bindings: pinctrl: rockchip: Add RMIO controller binding
Date: Thu, 25 Dec 2025 09:36:32 +0100 [thread overview]
Message-ID: <f58ccc03-286e-4ca0-acc4-6c6474a9df5c@kernel.org> (raw)
In-Reply-To: <8e126c63-1388-40ff-9046-818f7a8c969f@rock-chips.com>
On 25/12/2025 04:25, Ye Zhang wrote:
>>> +/* RMIO function definition */
>>> +#define RMIO_UART1_TX 1
>>> +#define RMIO_UART1_RX 2
>>> +#define RMIO_UART2_TX 3
>>> +#define RMIO_UART2_RX 4
>>> +#define RMIO_UART3_TX 5
>>> +#define RMIO_UART3_RX 6
>>> +#define RMIO_UART3_CTSN 7
>>> +#define RMIO_UART3_RTSN 8
>>> +#define RMIO_UART4_TX 9
>>> +#define RMIO_UART4_RX 10
>>> +#define RMIO_UART4_CTSN 11
>>> +#define RMIO_UART4_RTSN 12
>>> +#define RMIO_MIPITE 13
>>> +#define RMIO_CLK_32K 14
>>> +#define RMIO_I2C0_SCL 15
>>> +#define RMIO_I2C0_SDA 16
>>
>> I do not see how this is a binding. Please point me to the patch using
>> this in the driver.
> These macros are intended to be used in the Device Tree sources to
> improve readability, avoiding “magic numbers” for the RMIO function IDs.
That was not my question. Read again what I asked.
So not a binding, remove.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-25 8:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 11:20 [PATCH v3 0/7] pinctrl: rockchip: Add RK3506 and RV1126B pinctrl and RMIO support Ye Zhang
2025-12-16 11:20 ` [PATCH v3 1/7] pinctrl: rockchip: Add rk3506 pinctrl support Ye Zhang
2025-12-16 11:20 ` [PATCH v3 2/7] dt-bindings: pinctrl: Add rv1126b " Ye Zhang
2025-12-16 11:20 ` [PATCH v3 3/7] pinctrl: rockchip: " Ye Zhang
2025-12-16 11:20 ` [PATCH v3 4/7] arm64: dts: rockchip: rv1126b: Add pinconf and pinctrl dtsi for rv1126b Ye Zhang
2025-12-16 11:20 ` [PATCH v3 5/7] gpio: rockchip: support new version GPIO Ye Zhang
2025-12-16 11:20 ` [PATCH v3 6/7] dt-bindings: pinctrl: rockchip: Add RMIO controller binding Ye Zhang
2025-12-16 15:44 ` Rob Herring (Arm)
2025-12-16 15:52 ` Krzysztof Kozlowski
2025-12-25 6:44 ` Ye Zhang
[not found] ` <8e126c63-1388-40ff-9046-818f7a8c969f@rock-chips.com>
2025-12-25 8:36 ` Krzysztof Kozlowski [this message]
2025-12-26 18:07 ` Linus Walleij
2025-12-27 2:40 ` Ye Zhang
2026-01-04 11:44 ` Linus Walleij
2026-01-08 12:13 ` Ye Zhang
2026-01-09 10:19 ` Linus Walleij
2026-01-04 11:39 ` Linus Walleij
2025-12-16 11:20 ` [PATCH v3 7/7] pinctrl: rockchip: add rmio support Ye Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f58ccc03-286e-4ca0-acc4-6c6474a9df5c@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=tao.huang@rock-chips.com \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox