From: Can Guo <cang@codeaurora.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, rnayak@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] scsi: ufs: Add checks before setting clk-gating states
Date: Tue, 14 Jul 2020 12:11:53 +0800 [thread overview]
Message-ID: <f598fd46a548d86b7dd363351920341e@codeaurora.org> (raw)
In-Reply-To: <31ef233b-2562-2f61-d899-587092b5c033@acm.org>
Hi Bart,
On 2020-07-14 11:38, Bart Van Assche wrote:
> On 2020-07-13 19:28, Can Guo wrote:
>> @@ -2538,7 +2540,8 @@ static int ufshcd_queuecommand(struct Scsi_Host
>> *host, struct scsi_cmnd *cmd)
>> err = SCSI_MLQUEUE_HOST_BUSY;
>> goto out;
>> }
>> - WARN_ON(hba->clk_gating.state != CLKS_ON);
>> + if (ufshcd_is_clkgating_allowed(hba))
>> + WARN_ON(hba->clk_gating.state != CLKS_ON);
>
> A minor comment: has it been considered to change this into the
> following?
>
> WARN_ON(ufshcd_is_clkgating_allowed(hba) &&
> hba->clk_gating.state != CLKS_ON);
>
> Thanks,
>
> Bart.
Sure, will do that.
Thanks,
Can Guo.
next prev parent reply other threads:[~2020-07-14 4:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1594693693-22466-1-git-send-email-cang@codeaurora.org>
2020-07-14 2:28 ` [PATCH v2 1/4] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-07-14 3:38 ` Bart Van Assche
2020-07-14 4:11 ` Can Guo [this message]
2020-07-14 2:28 ` [PATCH v2 2/4] scsi: ufs: Fix imbalanced scsi_block_reqs_cnt caused by ufshcd_hold() Can Guo
2020-07-14 3:41 ` Bart Van Assche
2020-07-14 4:11 ` Can Guo
2020-07-14 2:28 ` [PATCH v2 3/4] ufs: ufs-qcom: Fix a few BUGs in func ufs_qcom_dump_dbg_regs() Can Guo
2020-07-14 3:47 ` Bart Van Assche
2020-07-14 4:17 ` Can Guo
2020-07-14 2:28 ` [PATCH v2 4/4] scsi: ufs: Fix up and simplify error recovery mechanism Can Guo
2020-07-14 3:52 ` Bart Van Assche
2020-07-14 4:26 ` Can Guo
2020-07-14 9:13 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f598fd46a548d86b7dd363351920341e@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox