The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yanteng Si <si.yanteng@linux.dev>
To: WangYuli <wangyuli@uniontech.com>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
	yonghong.song@linux.dev, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
	jolsa@kernel.org, corbet@lwn.net
Cc: bpf@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, void@manifault.com,
	psreep@gmail.com, yhs@fb.com, zhanjun@uniontech.com,
	niecheng1@uniontech.com, guanwentao@uniontech.com,
	Chen Linxuan <chenlinxuan@uniontech.com>
Subject: Re: [PATCH] bpf, docs: iterator: Rectify non-standard line break
Date: Thu, 24 Apr 2025 11:06:59 +0800	[thread overview]
Message-ID: <f5ac4ab8-bd1a-4009-bf09-1ac34eb47ec1@linux.dev> (raw)
In-Reply-To: <DB66473733449DB0+20250423030632.17626-1-wangyuli@uniontech.com>


在 4/23/25 11:06 AM, WangYuli 写道:
> Even though the kernel's coding-style document does not explicitly
> state this, we generally put a newline after the semicolon of every
> C language statement to enhance code readability.
>
> Adjust the placement of newlines to adhere to this convention.
>
> Reported-by: Chen Linxuan <chenlinxuan@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>

Reviewed-by: Yanteng Si <si.yanteng@linux.dev>


Thanks,

Yanteng

> ---
>   Documentation/bpf/bpf_iterators.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/bpf/bpf_iterators.rst b/Documentation/bpf/bpf_iterators.rst
> index 7f514cb6b052..385cd05aabf5 100644
> --- a/Documentation/bpf/bpf_iterators.rst
> +++ b/Documentation/bpf/bpf_iterators.rst
> @@ -323,8 +323,8 @@ Now, in the userspace program, pass the pointer of struct to the
>   
>   ::
>   
> -  link = bpf_program__attach_iter(prog, &opts); iter_fd =
> -  bpf_iter_create(bpf_link__fd(link));
> +  link = bpf_program__attach_iter(prog, &opts);
> +  iter_fd = bpf_iter_create(bpf_link__fd(link));
>   
>   If both *tid* and *pid* are zero, an iterator created from this struct
>   ``bpf_iter_attach_opts`` will include every opened file of every task in the

  reply	other threads:[~2025-04-24  3:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  3:06 [PATCH] bpf, docs: iterator: Rectify non-standard line break WangYuli
2025-04-24  3:06 ` Yanteng Si [this message]
2025-04-24 14:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5ac4ab8-bd1a-4009-bf09-1ac34eb47ec1@linux.dev \
    --to=si.yanteng@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chenlinxuan@uniontech.com \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=guanwentao@uniontech.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=niecheng1@uniontech.com \
    --cc=psreep@gmail.com \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=void@manifault.com \
    --cc=wangyuli@uniontech.com \
    --cc=yhs@fb.com \
    --cc=yonghong.song@linux.dev \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox