From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753194Ab0CIRjX (ORCPT ); Tue, 9 Mar 2010 12:39:23 -0500 Received: from mail-fx0-f213.google.com ([209.85.220.213]:62558 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578Ab0CIRjV convert rfc822-to-8bit (ORCPT ); Tue, 9 Mar 2010 12:39:21 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=DgJoZ3YWn/0voJS4XIG9ubn/PnEDCd4hZCFDCv/NOvCxxaUQeX/MDL5PoSBocEU9xa 1f62VyNQRTqUNDPS5C3uHU4nvDtPBK+h4e99MflhI3D3x4Q98MrIAcbCn8SIR63NakFp hsFQhXmmDQNMx+nvRX0/vejVlRV3TxGTp809o= MIME-Version: 1.0 In-Reply-To: <4B9683CF.5040402@intcomgrp.com> References: <4B967AEE.2060905@intcomgrp.com> <4B9683CF.5040402@intcomgrp.com> Date: Tue, 9 Mar 2010 14:39:19 -0300 Message-ID: Subject: Re: [PATCH] Security: key: keyring: fix some code style issues From: Chihau Chau To: James Kosin Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James 2010/3/9 James Kosin : > Chau, > > I was talking about removing the braces.  The code you pointed to still had > the style issue of this: >     } >     else { > > Where you changed the one below to be: >     } else { > This is done in the last patch > I'm okay with making a change like this.  Only don't remove the {} braces. Yes in the last patch I don't have remove the braces {} Now, It's everything OK? I will appreciate your councils. Regards. > > James > > On 3/9/2010 12:01 PM, Chihau Chau wrote: > > You said me that it may introduce a serious BUG later so I have undone > this change. > > Regards. > > 2010/3/9 James Kosin : > > > On 3/8/2010 6:20 PM, Chihau Chau wrote: > > > From: Chihau Chau > > This fixes to include instead and some > code style issues like to put a else sentence below close brace '}' and > to replace a tab instead of some space characters. > > Signed-off-by: Chihau Chau > --- >  security/keys/keyring.c |    7 +++---- >  1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/security/keys/keyring.c b/security/keys/keyring.c > index e814d21..840be66 100644 > --- a/security/keys/keyring.c > +++ b/security/keys/keyring.c > @@ -17,7 +17,7 @@ >  #include >  #include >  #include > -#include > +#include >  #include "internal.h" > >  /* > @@ -306,7 +306,7 @@ key_ref_t keyring_search_aux(key_ref_t keyring_ref, >       key_check(keyring); > >       /* top keyring must have search permission to begin the search */ > -        err = key_task_permission(keyring_ref, cred, KEY_SEARCH); > +     err = key_task_permission(keyring_ref, cred, KEY_SEARCH); >       if (err < 0) { >               key_ref = ERR_PTR(err); >               goto error; > @@ -775,8 +775,7 @@ int __key_link(struct key *keyring, struct key *key) >               smp_wmb(); >               klist->nkeys++; >               smp_wmb(); > -     } > -     else { > +     } else { >               /* grow the key list */ >               max = 4; >               if (klist) > > > Chau, > > What happened to the other part of the patch to fix the "} else {" above > where you had tried to remove the {} ? > > James > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Please read the FAQ at  http://www.tux.org/lkml/ > > > > > -- Chihau Chau