From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE79F3A5435; Wed, 15 Apr 2026 08:24:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776241482; cv=none; b=XOHs/PQ8uAgtHf2qolXs63fDipNYoKFeTQeXVQY2V3gTE3Ga1o5kiTmzS4bxR5Wi/insyg3YOkS8LAxUTkp7Mk596LyD/cFuT2hUi0qg4PK6dVHCtOhaUHqpK21wOZymZp4OFsTVroxgY7J4ez53YG+GFNXsnWNymL+rEH5tkb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776241482; c=relaxed/simple; bh=ITUjqoh6v/Y/cKBu7YDPhOAfAlNcg3tKnVNa0mtj7w8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tTKkVO7CtxX/GiiMITDUp8azbi7mhHHWVRzSEMGljvHo3rh2OMms9YHol4FjbVljwoqDyu8jHDEyRL0QTTeiTLoY5gXYlZKjeAc3saMscl9tZMUxyiotzvVdCbCiQ5p5Whm/ibc5YNN3Izgr+XE6tLj+d/pd5YGZcxaGhn9kCmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LyVUR+8B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LyVUR+8B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25B72C19424; Wed, 15 Apr 2026 08:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776241482; bh=ITUjqoh6v/Y/cKBu7YDPhOAfAlNcg3tKnVNa0mtj7w8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LyVUR+8BP1gmttUdKfvnKhM8aE2sTk7ziyAXBiG07kUatn5+VMxGkSSeRgJGAQaQT MQIqwMYcOr9JMVGvkv9gVMpLXweN74smMXYDJA37gYRf592KJLR60WFDSYv5JfXElp ofZmA7oLyy7aRiKo4NRG3+ldmJlb6zUDltjwiPNQlvdD8BrttLc2of79DjX10fsBr1 yu2Ge/9x6PO24KXhPG6sBxlmZ7UOIwMw6U9wlxwoYEUNAijAIGvXsIuLyitNBJDSWA my6haTNE9G1XSC+2TtI7OIrFSPnkTjMZ1TaWzPfQmlcAFQQo//zZkcv76KwTLYLUa7 lKHncYuZfQB0w== Message-ID: Date: Wed, 15 Apr 2026 10:24:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: add AMD MicroBlaze binding To: Michal Simek , Ben Levinsky , andersson@kernel.org, mathieu.poirier@linaro.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tanmay.shah@amd.com References: <20260414161558.2579920-1-ben.levinsky@amd.com> <20260414161558.2579920-2-ben.levinsky@amd.com> <774a8e9f-cfd9-4584-aaf0-2fd1189f65e8@kernel.org> <01f58865-3a89-4adf-9411-0bf8b8c985f7@amd.com> <9cd3686a-5fa6-49cc-9b38-96637b9fca39@kernel.org> <00aa7ec4-121b-430a-9b83-1430dfee2998@amd.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <00aa7ec4-121b-430a-9b83-1430dfee2998@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/04/2026 10:06, Michal Simek wrote: > > > On 4/15/26 09:07, Krzysztof Kozlowski wrote: >> On 15/04/2026 08:55, Michal Simek wrote: >>>>> >>>>> Does it make sense? >>>> >>>> Yes, drop from DT. No need for generic stuff. Or describe the hardware. >>> >>> You need to describe that connection to HW. GPIOs, memory location, etc. >>> It means there must be any description. >> >> No, you can write user-space driver or pass everything through SW nodes. >> No need for DT description. > > The firmware memory typically sits behind AXI-to-AXI bridges and > > interconnect switches. The bus topology varies between FPGA designs. > > DT ranges-based address translation is the standard way to describe > > this, and pushing it into userspace would just mean hardcoding what > > ranges already provides. > > I don't think SW nodes should be used here. > >> >> But if you want a DT description, then it must be for the specific >> hardware, since the hardware is not generic. > > But there is specific HW loaded. It is loaded at power up and don't change over > life cycle. What I am just saying that access to this fixed HW (in fpga) is > generic. At this stage memory and gpio only. > > What I was trying to say is that the hardware topology (memory window + > > reset GPIO) is the same regardless of the soft-core cpu (MicroBlaze, > RISC-V, etc.)/fpga, so naming it after the ISA architecture felt wrong to me > > too. > > When I look at other bindings. For example this one. > Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml That's a subnode of other device. Not an independent device. Plus I dislike most of Qualcomm remoteproc bindings and find them way to downstreamish, written to match downstream approaches without respecting DT rules. > > the compatible describes the communication mechanism (FIFO-based G-Link), not > the specific processor behind it. > > > > Our case is similar the compatible describes the control mechanism firmware > loaded through a memory window, processor started via GPIO reset. What sits > behind that interface varies and is opaque to the binding. > > > Would something like "amd,mem-gpio-rproc" be acceptable, following the same > pattern where the compatible identifies the interface mechanism? Not for me. You have a very specific physical remote processor. That's what you write bindings for. Best regards, Krzysztof