From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C81931E821 for ; Tue, 14 Jul 2026 17:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784051322; cv=none; b=hX2+P5sczAYrU1cbQo8k0DuPGT3OHbswXBQ56bWImI3AUKbWciULvWFglbsM4ReCRAzvdyDyAlESIHI+pnRmQP4yXCEoWwhLGsW0p/Y+sDf8533GmmLNUU6/9O5d3izqcLOFIANwrmtf8QpcfXBuGt0qEbqvBse3XSyOorLSjKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784051322; c=relaxed/simple; bh=IFAu/AhxORYk2IwnhBrpXKy17QBG4QbHZp5F52W9HMk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G+BZt62ekV0blv4tH2Z7ApZNjFyeI1wM+Wdj9N3+RAab/QY2zbKTcAiC6MyDhi4VgdHLIVQRg5iZQEi05r70HLM7A6H+RBhRMtfQ+IIKk0LvNqQell44T4gsacYT9bWeHCG3d2hgupTpg9KM7oXqz+B9PCsRVBbOQn2lKtpHGIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=C+zGCpj8; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="C+zGCpj8" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47f3b39f2a1so882460f8f.2 for ; Tue, 14 Jul 2026 10:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784051295; x=1784656095; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=e8wrUq4T5WG/sDi1QzY5+qWQz+ouZt+E86zcQiC6M5Y=; b=C+zGCpj8Ki941D0TPKfjudTMiW8wnU3KkXr4QFQMbPSaL9rIyniEnwvQZFiFhtnsNZ Gd8ISSrNgZlC70mQOVR4x6oLGKF/EvYWfHa2c2CeoakM7+8MjdI2mWxyJmU2T1f7r9H1 Pa7LULVxmyT8v+5JGSdyBESTcMuRVcKzkLaba4mMGrgbv3sBOFuEZspQAFvr4rm3aODx jscIa4/BLneKOQQKJo6Xj1Azuc9c5dXpGEFVyuxasL7l0WQ6zcQSc/U1iyRDS+iOGZjl PzGsxsTxd3U1WiJ6yTBMma3jeqNnljxjDCw/vfDPTTqOaXZ0v36MKIyO0e80DwY8He0g QQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784051295; x=1784656095; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=e8wrUq4T5WG/sDi1QzY5+qWQz+ouZt+E86zcQiC6M5Y=; b=j2B8biDLt/yaY8N+KRI5GvUs6lYHXbRzCtL7zoPJOcZoS/ncgdIFKGliZTa9lTqQIk Zjfr4bXgfr4C7Z7brP8uldRS7DkTzEd1pGKHJ7FRqBPmH9MYJY96dp8Az36QTPEDBvlM cRCX6qZHQNbH9rBRzkLh/1+OkWkZPJ8upbmn48mtZRpx54ra8uLjyEZfgsN1fVN9YjIk 0FP7kOVshrp8zVbscQd5Z78MwHuvhuFzoAVYpZvBvBlTFf7in6E93HmjXBCHLy4zQU16 3YmHGdupu2hn3U7aiaN0vWu5gJwKV8M5LgA4yEKK7JRCJsDQYF4WLKxbV7yR13Rxf/GJ fHFw== X-Forwarded-Encrypted: i=1; AHgh+Rq6FkHtjsseA6mRcTnmcbv6MwiD52wwRqCJK85lq7q6gIL02sNxrRce11lZ+nZ9kWsXUpN6d++OArqsMzw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5uqfgxX7l+iCsYjEj4BKvodgr2wzlzHK7dCx9f/Yoacx3/hqB 7u4cDjdUwW5o8jBOfawR/OKQRe11OeLS2HUCeYRHAjlC/GllwRhbK1/X+L7Qgif8sFU= X-Gm-Gg: AfdE7cl5lkDWdeN1QWRQcSWE0kyS8NHmt8f7w7n4U4y5RG5aQ4exvFWR+oapzAvYEOR 8pdP6lVOgvqKbcVbapeJhpECPfDhn4lAcuc8Uus5ZOXFNHa/cww6kFW1Modi1UWZNyfs15xh77j CmS77wMVTF7gJlz7RkIcRVThHQNW30KL0iNRUHehVY2JEqPK3RqURIRz6SygbFK/b8AgpGp53/J hv0V08386XZs9zEvROeaDiklg5AfHN5rSTWaHPPZhWI4NFCgraT5LZ3aQ3TYZ8r0+JxJcFeOMlz nQRrr3spVBWcIS9smOcB3lbqBJttKS6hHIaBGUKSUzadRX20Q3gGBAShQDav7L4K1YN7itDYK0W S2HeTMcez/AUPrZOwQtN5u7KJak3xpoU0nfy8cE9DdFg2X1r56SVES9Urlb8TC1CEsV0glySF2C yBwdul3zUIH3MsLmW41qSdBNpdihcBhaUpaeEbIaM89tOSyUDt+xwf6QQ= X-Received: by 2002:a05:6000:40ca:b0:47d:fc20:e7b4 with SMTP id ffacd0b85a97d-47f2dcb5c7amr16880409f8f.10.1784051295376; Tue, 14 Jul 2026 10:48:15 -0700 (PDT) Received: from ?IPV6:2001:a61:13c3:1c01:3157:c849:4aaa:fa65? ([2001:a61:13c3:1c01:3157:c849:4aaa:fa65]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464a974csm11710975f8f.18.2026.07.14.10.48.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 10:48:15 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 19:48:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: core: Strengthen error handling in hub_hub_status() To: Alan Stern , Griffin Kroah-Hartman Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260714-usb_core_patches_2-v1-1-4229a368a633@kroah.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.07.26 18:32, Alan Stern wrote: >> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c >> index 5262e11c12cd..0d2166b8923a 100644 >> --- a/drivers/usb/core/hub.c >> +++ b/drivers/usb/core/hub.c >> @@ -991,10 +991,12 @@ static int hub_hub_status(struct usb_hub *hub, >> >> mutex_lock(&hub->status_mutex); >> ret = get_hub_status(hub->hdev, &hub->status->hub); >> - if (ret < 0) { >> + if (ret < sizeof(hub->status->hub)) { >> if (ret != -ENODEV) >> dev_err(hub->intfdev, >> "%s failed (err = %d)\n", __func__, ret); >> + if (ret >= 0) >> + ret = -EIO; > > It would be better to put these two lines above the preceding test. > That way it won't print confusing things like "hub_hub_status failed > (err = 2)". I am afraid I have to disagree. We would in effect say that get_hub_status() has returned -EIO. That is simply not true. Regards Oliver