From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Ankit Agrawal <ankita@nvidia.com>
Cc: "alex@shazbot.org" <alex@shazbot.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"jgg@ziepe.ca" <jgg@ziepe.ca>, Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum Thodi <skolothumtho@nvidia.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v4 1/1] vfio/nvgrace-gpu: Add Blackwell-Next GPU readiness check via CXL DVSEC
Date: Wed, 22 Apr 2026 15:44:40 +0300 (EEST) [thread overview]
Message-ID: <f5f24e2f-c341-f948-e6d7-b3a3a54a07af@linux.intel.com> (raw)
In-Reply-To: <SA1PR12MB7199D0D2BAD762A5F2B2D78FB02C2@SA1PR12MB7199.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Tue, 21 Apr 2026, Ankit Agrawal wrote:
> Thanks for the review Ilpo!
>
> >> + * Decode the 3-bit Memory_Active_Timeout field from CXL DVSEC Range 1 Low
> >> + * (bits 15:13) into milliseconds. Encoding per CXL spec r4.0 sec 8.1.3.8.2:
> >> + * 000b = 1s, 001b = 4s, 010b = 16s, 011b = 64s, 100b = 256s,
> >> + * 101b-111b = reserved (clamped to 256s).
> >> + */
> >> +static inline unsigned long cxl_mem_active_timeout_ms(u8 timeout)
> >> +{
> >> + return 1000UL << (2 * min_t(u8, timeout, 4));
> >
> > MSEC_PER_SEC
>
> Ack.
I didn't see this change in v5.
> > Also, don't forget to add include for units.h.
>
> Sorry why do we need to do this? The MSEC_PER_SEC is getting included through
> jiffies.h.
Sorry, I mixed from what header it comes from and it doesn't exactly
comes from jiffies.h either. If C files rely on indirect includes
through other header, it makes painful to refactor headers.
--
i.
next prev parent reply other threads:[~2026-04-22 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 14:06 [PATCH v4 1/1] vfio/nvgrace-gpu: Add Blackwell-Next GPU readiness check via CXL DVSEC Ankit Agrawal
2026-04-21 14:16 ` Ilpo Järvinen
2026-04-21 15:13 ` Ankit Agrawal
2026-04-22 12:44 ` Ilpo Järvinen [this message]
2026-04-22 13:53 ` Ankit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5f24e2f-c341-f948-e6d7-b3a3a54a07af@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=alex@shazbot.org \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox