From: Shuah Khan <skhan@linuxfoundation.org>
To: Petteri Aimonen <jpa@git.mail.kapsi.fi>
Cc: Andy Lutomirski <luto@amacapital.net>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Shuah Khan <shuah@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] arch/x86: reset MXCSR to default in kernel_fpu_begin()
Date: Thu, 11 Jun 2020 08:38:18 -0600 [thread overview]
Message-ID: <f5f80b20-c8e8-4f75-c5b2-dbd7ce56ca41@linuxfoundation.org> (raw)
In-Reply-To: <20200603051946.GF17423@lakka.kapsi.fi>
On 6/2/20 11:19 PM, Petteri Aimonen wrote:
> Hi,
>
>> Is it correct to assume the stuff checked differs from test to test
>> and done in user-space.
>>
>>> undo_evil_state();
>>
>> Is it correct to assume undoing evil differs from test to test
>> and done in user-space, provide it can be done from userspace.
>
> Yes, currently the test works like:
>
> do_test_setup();
> read_from_debugfs_file();
> check_results();
>
You will need a 4th clanup step step of undo_test_setup().
> and the middle step stays the same. But of course in general case there
> could be argument passing etc, even though the test for this issue
> doesn't need them.
>
> Myself I don't see the problem with just adding a file under debugfs and
> bind to its read.
>
thanks,
-- Shuah
next prev parent reply other threads:[~2020-06-11 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 10:11 [PATCH] arch/x86: reset MXCSR to default in kernel_fpu_begin() Borislav Petkov
2020-06-02 10:29 ` Petteri Aimonen
2020-06-02 10:56 ` Borislav Petkov
2020-06-02 17:03 ` Andy Lutomirski
2020-06-02 17:27 ` Shuah Khan
2020-06-02 19:50 ` Andy Lutomirski
2020-06-02 20:25 ` Shuah Khan
2020-06-03 5:19 ` Petteri Aimonen
2020-06-11 14:38 ` Shuah Khan [this message]
2020-06-11 7:36 ` Petteri Aimonen
2020-06-11 9:18 ` Borislav Petkov
2020-06-11 14:19 ` Andy Lutomirski
2020-06-11 14:50 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5f80b20-c8e8-4f75-c5b2-dbd7ce56ca41@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=jpa@git.mail.kapsi.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox