From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751988AbdIUIN1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Sep 2017 04:13:27 -0400
Received: from mout.web.de ([212.227.17.11]:55719 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751530AbdIUINZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Sep 2017 04:13:25 -0400
Subject: Re: [media] s2255drv: Adjust 13 checks for null pointers
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Bhumika Goyal <bhumirks@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Mike Isely <isely@pobox.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <55718a41-d76f-36bf-7197-db92014dcd3c@users.sourceforge.net>
 <66f0b95e-e717-7a50-39d2-05fcbf7b77bd@users.sourceforge.net>
 <20170920230729.b2jujsdcjtvjrjun@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f5fde857-e0d2-1189-7764-dd82ca5df84a@users.sourceforge.net>
Date: Thu, 21 Sep 2017 10:12:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170920230729.b2jujsdcjtvjrjun@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:n8MgUk5DFT2ssIey+UIlmZjQsxA48DYYa/bTUXQSmrYSYKLgoFD
 0aFTH3ojZuF7mHa/g4XT4JrzdApJJWVUAN7X+50PY39FYMf3spD5CAZ4pJBhTNKc2gptkgy
 lVUusRySZuA4XQOavEB/FVuUITgt0/GIIL5Pj1w18RgPCCjtv+lWJ+zyEaNQk41SislA9/h
 39J0FYxw81Ab+BPsurQsw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:VgyFgfOzVV4=:Kv6nQ7YGnLbml2BVfNVM/9
 BwWjRUEBfN6KAPqmsbENtPy9BMwX6WoFdJ+c5XLvdkljVqu0i+3ZxSOkiR8vfxizE/nKooesE
 df4pXzmrHXW5O0F0TDfJZmfKPN0v17rqFmma/yoE1mK0fNxvwMzFZ4PdL/aLCxWkpSIhZ6RXd
 ihWxZlLcOeS0G4kkVgkLhMi5H8QwZ4YsB2Zge+Fr+SFkPQevyehctp4UCvo01KIyzwoADTHhK
 C/rD6KXYkXUYPo3//mmn/Mt3p/D24KrrS83NH9cMGveBHYlpb7TV7KNmTP+zMULBHqSTqf1if
 4BFJfTfNIj9CT70KXlzJws7d+bpi1bhgWBFLAZb3rmIzwLdIYtPjO/K/msflcff3lNWkWC9mz
 8OWBsqNjwKdVsWBt6vRsJzKTzU2NgKcHTAu+x9nqfjCr63DeC5edy3cP8uPSJ197aBSVmmyxZ
 6i5NFl+fRSrKVAVSinyA8ji04SiIHAaLyZ85ivNr7+LJZlS3CwUnu/yqvJuaqRS1+uGLV0wxh
 QGjjWOqtSGqEU0IXrR+EEuwsFbK+x1S6wqqeFNaM2a2HwuG20EBmY0u6AyzUos84GJk0q/s6z
 3pnD9XBz/hrzxjz5n6f012Dw9EdmfQqvJYUASLNEsMNp/XS78YI7lsBV9VDEotWbB8sVYBBgD
 5BfNry2XSaSPxZD12l2fdN5u12dgSVykEol6RwuQjWPScfq41aWTQglXqeJryfzT/u1rIfJxZ
 kFVzhmK76mTcfZhpzL1wTVsKB0aJFCQIvc9duf7TW2k3w2YDtbSYHrwwJJu1fAgaHcPyD1wGD
 ci576djCByHQD/BTq6u2fyXvX1p64b8nNkcC9i+hKzajFiiy3s=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
> 
> You've been told several times that this stuff doesn't work.

This functionality might not exactly work in the way that you expect so far.


> Try applying this patch with `git am` and you'll see why.

I find that these extra message fields work in the way that was designed
by the Git software developers.

elfring@Sonne:~/Projekte/Linux/next-patched> LANG=C git checkout -b next_deletion_of_oom_messages_in_s2255drv_test_20170921 next_deletion_of_oom_messages-20170905 && LANG=C git am '../[PATCH 2_5] [media] s2255drv: Adjust 13 checks for null pointers.eml'
Switched to a new branch 'next_deletion_of_oom_messages_in_s2255drv_test_20170921'
Applying: s2255drv: Adjust 13 checks for null pointers


Would you like to clarify corresponding concerns any more?

Regards,
Markus