* [PATCH] platform/x86: huawei-wmi: add keys for HONOR models
@ 2025-10-14 15:19 ston
2025-10-15 8:30 ` Ilpo Järvinen
0 siblings, 1 reply; 7+ messages in thread
From: ston @ 2025-10-14 15:19 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen; +Cc: platform-driver-x86, linux-kernel
HONOR MagicBook X16/X14 models-
produced in 2025 cannot use the print key properly.
(input input25: Unknown key pressed, code: 0x028b)
This patch fixes this function.
Signed-off-by: ston <ston.jia@outlook.com>
---
drivers/platform/x86/huawei-wmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index c3772df34..d3b7b673d 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -81,6 +81,9 @@ static const struct key_entry huawei_wmi_keymap[] = {
{ KE_KEY, 0x289, { KEY_WLAN } },
// Huawei |M| key
{ KE_KEY, 0x28a, { KEY_CONFIG } },
+ // HONOR keys
+ { KE_KEY, 0x28b, { KEY_NOTIFICATION_CENTER } },
+ { KE_KEY, 0x28e, { KEY_PRINT } },
// Keyboard backlit
{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] platform/x86: huawei-wmi: add keys for HONOR models
2025-10-14 15:19 [PATCH] platform/x86: huawei-wmi: add keys for HONOR models ston
@ 2025-10-15 8:30 ` Ilpo Järvinen
2025-10-15 13:27 ` [PATCH v2] " Jia Ston
2025-10-16 10:23 ` [PATCH v4] " Jia Ston
0 siblings, 2 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-10-15 8:30 UTC (permalink / raw)
To: ston; +Cc: Hans de Goede, platform-driver-x86, LKML
On Tue, 14 Oct 2025, ston wrote:
> HONOR MagicBook X16/X14 models-
That dash seems misplaced in middle of a sentence.
> produced in 2025 cannot use the print key properly.
> (input input25: Unknown key pressed, code: 0x028b)
>
> This patch fixes this function.
Please use more precise wording and avoid starting with "This patch" (or
similar phrases such as "This change").
>
> Signed-off-by: ston <ston.jia@outlook.com>
Please use full name in sign off.
> ---
> drivers/platform/x86/huawei-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index c3772df34..d3b7b673d 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -81,6 +81,9 @@ static const struct key_entry huawei_wmi_keymap[] = {
> { KE_KEY, 0x289, { KEY_WLAN } },
> // Huawei |M| key
> { KE_KEY, 0x28a, { KEY_CONFIG } },
> + // HONOR keys
> + { KE_KEY, 0x28b, { KEY_NOTIFICATION_CENTER } },
> + { KE_KEY, 0x28e, { KEY_PRINT } },
You only mentioned single key in the changelog but are adding two here?
Please amend the changelog to cover the changes fully.
> // Keyboard backlit
> { KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
> { KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
>
--
i.
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2] platform/x86: huawei-wmi: add keys for HONOR models
2025-10-15 8:30 ` Ilpo Järvinen
@ 2025-10-15 13:27 ` Jia Ston
2025-10-15 13:47 ` [PATCH v3] " Jia Ston
2025-10-16 10:23 ` [PATCH v4] " Jia Ston
1 sibling, 1 reply; 7+ messages in thread
From: Jia Ston @ 2025-10-15 13:27 UTC (permalink / raw)
To: ilpo.jarvinen@linux.intel.com
Cc: hansg@kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, Jia Ston
From: ston <ston.jia@outlook.com>
HONOR MagicBook X16/X14 models produced in 2025 cannot use the print and YOYO key properly.
This change add key_entry for HONOR printscreen key and HONOR YOYO key.
Signed-off-by: Ston Jia <ston.jia@outlook.com>
---
drivers/platform/x86/huawei-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index c3772df34..8a4c54089 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -81,6 +81,10 @@ static const struct key_entry huawei_wmi_keymap[] = {
{ KE_KEY, 0x289, { KEY_WLAN } },
// Huawei |M| key
{ KE_KEY, 0x28a, { KEY_CONFIG } },
+ // HONOR YOYO key
+ { KE_KEY, 0x28b, { KEY_NOTIFICATION_CENTER } },
+ // HONOR print screen
+ { KE_KEY, 0x28e, { KEY_PRINT } },
// Keyboard backlit
{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v3] platform/x86: huawei-wmi: add keys for HONOR models
2025-10-15 13:27 ` [PATCH v2] " Jia Ston
@ 2025-10-15 13:47 ` Jia Ston
0 siblings, 0 replies; 7+ messages in thread
From: Jia Ston @ 2025-10-15 13:47 UTC (permalink / raw)
To: Jia Ston
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
From: ston <ston.jia@outlook.com>
HONOR MagicBook X16/X14 models produced in 2025 cannot use the print and YOYO key properly.
(input input25: Unknown key pressed, code: 0x028b)
(input input25: Unknown key pressed, code: 0x028e)
This change add key_entry for HONOR printscreen key and HONOR YOYO key.
Signed-off-by: Ston Jia <ston.jia@outlook.com>
---
V1 -> V2: Add key_entry changes to commit message
V2 -> V3: Add error output to commit message
drivers/platform/x86/huawei-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index c3772df34..8a4c54089 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -81,6 +81,10 @@ static const struct key_entry huawei_wmi_keymap[] = {
{ KE_KEY, 0x289, { KEY_WLAN } },
// Huawei |M| key
{ KE_KEY, 0x28a, { KEY_CONFIG } },
+ // HONOR YOYO key
+ { KE_KEY, 0x28b, { KEY_NOTIFICATION_CENTER } },
+ // HONOR print screen
+ { KE_KEY, 0x28e, { KEY_PRINT } },
// Keyboard backlit
{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4] platform/x86: huawei-wmi: add keys for HONOR models
2025-10-15 8:30 ` Ilpo Järvinen
2025-10-15 13:27 ` [PATCH v2] " Jia Ston
@ 2025-10-16 10:23 ` Jia Ston
2025-10-29 5:18 ` [Resend PATCH " Jia Ston
1 sibling, 1 reply; 7+ messages in thread
From: Jia Ston @ 2025-10-16 10:23 UTC (permalink / raw)
To: ilpo.jarvinen@linux.intel.com
Cc: hansg@kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, Jia Ston
HONOR MagicBook X16/X14 models produced in 2025 cannot use
the Print Screen and YOYO keys properly, with the system
reporting them as unknown key presses (codes: 0x028b and 0x028e).
To resolve this, the key_entry is added for both the
HONOR Print Screen key and the HONOR YOYO key, ensuring
they function correctly on these models.
Signed-off-by: Ston Jia <ston.jia@outlook.com>
---
V1 -> V2: Add key_entry changes to commit message
V2 -> V3: Add error output to commit message
V3 -> V4: More detailed commit information
drivers/platform/x86/huawei-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index c3772df34..8a4c54089 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -81,6 +81,10 @@ static const struct key_entry huawei_wmi_keymap[] = {
{ KE_KEY, 0x289, { KEY_WLAN } },
// Huawei |M| key
{ KE_KEY, 0x28a, { KEY_CONFIG } },
+ // HONOR YOYO key
+ { KE_KEY, 0x28b, { KEY_NOTIFICATION_CENTER } },
+ // HONOR print screen
+ { KE_KEY, 0x28e, { KEY_PRINT } },
// Keyboard backlit
{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Resend PATCH v4] platform/x86: huawei-wmi: add keys for HONOR models
2025-10-16 10:23 ` [PATCH v4] " Jia Ston
@ 2025-10-29 5:18 ` Jia Ston
2025-11-05 12:23 ` Ilpo Järvinen
0 siblings, 1 reply; 7+ messages in thread
From: Jia Ston @ 2025-10-29 5:18 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia Ston
HONOR MagicBook X16/X14 models produced in 2025 cannot use
the Print Screen and YOYO keys properly, with the system
reporting them as unknown key presses (codes: 0x028b and 0x028e).
To resolve this, the key_entry is added for both the
HONOR Print Screen key and the HONOR YOYO key, ensuring
they function correctly on these models.
Signed-off-by: Ston Jia <ston.jia@outlook.com>
---
V1 -> V2: Add key_entry changes to commit message
V2 -> V3: Add error output to commit message
V3 -> V4: More detailed commit information
drivers/platform/x86/huawei-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index c3772df34..8a4c54089 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -81,6 +81,10 @@ static const struct key_entry huawei_wmi_keymap[] = {
{ KE_KEY, 0x289, { KEY_WLAN } },
// Huawei |M| key
{ KE_KEY, 0x28a, { KEY_CONFIG } },
+ // HONOR YOYO key
+ { KE_KEY, 0x28b, { KEY_NOTIFICATION_CENTER } },
+ // HONOR print screen
+ { KE_KEY, 0x28e, { KEY_PRINT } },
// Keyboard backlit
{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Resend PATCH v4] platform/x86: huawei-wmi: add keys for HONOR models
2025-10-29 5:18 ` [Resend PATCH " Jia Ston
@ 2025-11-05 12:23 ` Ilpo Järvinen
0 siblings, 0 replies; 7+ messages in thread
From: Ilpo Järvinen @ 2025-11-05 12:23 UTC (permalink / raw)
To: Hans de Goede, Jia Ston; +Cc: platform-driver-x86, linux-kernel
On Wed, 29 Oct 2025 05:18:38 +0000, Jia Ston wrote:
> HONOR MagicBook X16/X14 models produced in 2025 cannot use
> the Print Screen and YOYO keys properly, with the system
> reporting them as unknown key presses (codes: 0x028b and 0x028e).
>
> To resolve this, the key_entry is added for both the
> HONOR Print Screen key and the HONOR YOYO key, ensuring
> they function correctly on these models.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: huawei-wmi: add keys for HONOR models
commit: 6eee991995b16a1b0a266ce9081fa130f82f98ff
[1/1] platform/x86: huawei-wmi: add keys for HONOR models
commit: 6eee991995b16a1b0a266ce9081fa130f82f98ff
--
i.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-11-05 12:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 15:19 [PATCH] platform/x86: huawei-wmi: add keys for HONOR models ston
2025-10-15 8:30 ` Ilpo Järvinen
2025-10-15 13:27 ` [PATCH v2] " Jia Ston
2025-10-15 13:47 ` [PATCH v3] " Jia Ston
2025-10-16 10:23 ` [PATCH v4] " Jia Ston
2025-10-29 5:18 ` [Resend PATCH " Jia Ston
2025-11-05 12:23 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox