* [PATCH] media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci_remove()
@ 2024-05-20 9:55 Christophe JAILLET
2024-05-20 11:54 ` Bingbu Cao
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-05-20 9:55 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao, Tianshu Qiu, Mauro Carvalho Chehab,
Hans Verkuil
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-media
pcim_iomap_regions() and pcim_enable_device() are used in the probe. So
the corresponding managed resources don't need to be freed explicitly in
the remove function.
Remove the incorrect pci_release_regions() and pci_disable_device() calls.
Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
drivers/media/pci/intel/ipu6/ipu6.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
index d2bebd208461..f587f609259d 100644
--- a/drivers/media/pci/intel/ipu6/ipu6.c
+++ b/drivers/media/pci/intel/ipu6/ipu6.c
@@ -727,9 +727,6 @@ static void ipu6_pci_remove(struct pci_dev *pdev)
pm_runtime_forbid(&pdev->dev);
pm_runtime_get_noresume(&pdev->dev);
- pci_release_regions(pdev);
- pci_disable_device(pdev);
-
release_firmware(isp->cpd_fw);
ipu6_mmu_cleanup(psys_mmu);
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci_remove()
2024-05-20 9:55 [PATCH] media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci_remove() Christophe JAILLET
@ 2024-05-20 11:54 ` Bingbu Cao
0 siblings, 0 replies; 2+ messages in thread
From: Bingbu Cao @ 2024-05-20 11:54 UTC (permalink / raw)
To: Christophe JAILLET, Sakari Ailus, Bingbu Cao, Tianshu Qiu,
Mauro Carvalho Chehab, Hans Verkuil
Cc: linux-kernel, kernel-janitors, linux-media
Christophe,
Thanks for the patch.
On 5/20/24 5:55 PM, Christophe JAILLET wrote:
> pcim_iomap_regions() and pcim_enable_device() are used in the probe. So
> the corresponding managed resources don't need to be freed explicitly in
> the remove function.
>
> Remove the incorrect pci_release_regions() and pci_disable_device() calls.
>
> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> drivers/media/pci/intel/ipu6/ipu6.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> index d2bebd208461..f587f609259d 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> @@ -727,9 +727,6 @@ static void ipu6_pci_remove(struct pci_dev *pdev)
> pm_runtime_forbid(&pdev->dev);
> pm_runtime_get_noresume(&pdev->dev);
>
> - pci_release_regions(pdev);
> - pci_disable_device(pdev);
> -
> release_firmware(isp->cpd_fw);
>
> ipu6_mmu_cleanup(psys_mmu);
>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
--
Best regards,
Bingbu Cao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-20 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-20 9:55 [PATCH] media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci_remove() Christophe JAILLET
2024-05-20 11:54 ` Bingbu Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox