From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751465AbdJWKtz (ORCPT ); Mon, 23 Oct 2017 06:49:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33924 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbdJWKtx (ORCPT ); Mon, 23 Oct 2017 06:49:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 77428603D2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH v2 14/17] phy: qcom-qusb2: Set vbus sw-override signal in device mode From: Manu Gautam To: Jack Pham , Kishon Vijay Abraham I Cc: Felipe Balbi , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Vivek Gautam , Krzysztof Kozlowski , "open list:GENERIC PHY FRAMEWORK" References: <1506502753-27408-1-git-send-email-mgautam@codeaurora.org> <1506502753-27408-15-git-send-email-mgautam@codeaurora.org> <20170927175741.GA12812@usblab-sd-06.qualcomm.com> <20170927191643.GC12812@usblab-sd-06.qualcomm.com> <6126ccb9-ca4e-8219-660f-aa36b7d895ba@codeaurora.org> <20170928165345.GD12812@usblab-sd-06.qualcomm.com> <3f3ffa94-867d-f348-5041-f1e6a24e662a@codeaurora.org> <56b4355d-ab01-e2dd-5ad5-815facc5bb78@codeaurora.org> Message-ID: Date: Mon, 23 Oct 2017 16:19:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <56b4355d-ab01-e2dd-5ad5-815facc5bb78@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, Please review this so that I can re-submit patch-set based on this approach. On 10/9/2017 1:33 PM, Manu Gautam wrote: > Hi Kishon > > On 10/5/2017 2:38 PM, Manu Gautam wrote: >> Kishon, >> What would you suggest here? >> Should we add new calls e.g. phy_get/set_current_speed like:: >> >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >> index 78bb0d7..41d9ec2 100644 >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -29,6 +29,14 @@ enum phy_mode { >>         PHY_MODE_USB_OTG, >>  }; >> >> +enum phy_speed { >> +       PHY_SPEED_INVALID, >> +       PHY_SPEED_USB_LS, >> +       PHY_SPEED_USB_FS_HS, >> +       PHY_SPEED_USB_SS, >> +}; >> + >>  /** >>   * struct phy_ops - set of function pointers for performing phy operations >>   * @init: operation to be performed for initializing phy >> @@ -45,6 +53,7 @@ struct phy_ops { >>         int     (*power_on)(struct phy *phy); >>         int     (*power_off)(struct phy *phy); >>         int     (*set_mode)(struct phy *phy, enum phy_mode mode); >> +       int     (*set_speed)(struct phy *phy, enum phy_speed speed); >>         int     (*reset)(struct phy *phy); >>         struct module *owner; >>  }; >> > @Kishon, > Let me know if we can add set_speed to phy_ops. We need this for glue > driver to notify PHY of current connection speed to enable appropriate > wakeup interrupts. > > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project