From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484312BB09 for ; Thu, 12 Sep 2024 14:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726150995; cv=none; b=YO4qasVBTBKgMf00nz3fOqAWMCVG8xHPxBL1FSp4Lh4NtiEj0XBPyi+lAZmEq7EnkNHMSwhB5LrtEa9SyhrosCM6OScEPAnCqAh7YlLqtNz50WOOtGOSVQLuQ20hfowL8HNbRbLjvZwNtt/OBNYrer2kgJ+iSAp78lWZFCihoSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726150995; c=relaxed/simple; bh=oWzSbl9SOryhrEfvgC31aG2vf60JanCUGc273K6cBVg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OOZmdcRhCN0vWznUBmwYXYz2XrDX6RDXwONkeqSDLlUNiMfviFTMpXlHgv7sFcC4gduPTWmmag5w6fY8v2Xe2pzqglVcBlbv3p+yHqf4bO2yhHFYuLv4d+Ef+kgX6nqe8WIMUwrQRMk+ftCuoJesnQy9dCkJkUdTRexqO/QX+dw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Dmzhz82m; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Dmzhz82m" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726150991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JQcj2YDJcPOkha5AjFb9sgabfqS/mkYXHsp1WXdSRE0=; b=Dmzhz82mKpoK7vDeWNHJ8FrrSmRqWeE4p4A2Gg7IU4qsDs5hfY+ZYc7GEvOoOQOfqMkUMX kncnb80/XNvOBRgi8lkmllfzNjB7cho4BWysXMLUfH7qP1RXO8+3J8wi6763V7vo77VvX7 l+qodB+IidCdHyBcI9NN0+g9d/sni84= Date: Thu, 12 Sep 2024 10:23:06 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net] net: xilinx: axienet: Schedule NAPI in two steps To: Jakub Kicinski Cc: Radhey Shyam Pandey , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Robert Hancock , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org References: <20240909231904.1322387-1-sean.anderson@linux.dev> <20240910185801.42b7c17f@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240910185801.42b7c17f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 9/10/24 21:58, Jakub Kicinski wrote: > On Mon, 9 Sep 2024 19:19:04 -0400 Sean Anderson wrote: >> Additionally, since we are running >> in an IRQ context we can use the irqoff variant as well. > > The _irqoff variant is a bit of a minefield. It causes issues if kernel > is built with forced IRQ threading. With datacenter NICs forced > threading is never used so we look the other way. Since this is a fix > and driver is embedded I reckon we should stick to __napi_schedule(). Does it? __napi_schedule_irqoff selects between __napi_schedule and ____napi_schedule based on whether PREEMPT_RT is enabled. Is there some other way to force IRQ threading? --Sean