From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Tanjuate Brunostar <tanjubrunostar0@gmail.com>,
gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c
Date: Tue, 1 Nov 2022 23:15:37 +0100 [thread overview]
Message-ID: <f67a1a02-addf-3197-e423-7c66ab97f6df@gmail.com> (raw)
In-Reply-To: <cover.1667326000.git.tanjubrunostar0@gmail.com>
On 11/1/22 19:17, Tanjuate Brunostar wrote:
> These fixes are focused on the function s_vFillRTSHead
>
> v3: changed the function name from fill_rts_head to fill_rts_header as
> head is conventionally used in lists
>
> v2: changed confusing changelog messages
>
> Tanjuate Brunostar (2):
> staging: vt6655: change the function name s_vFillRTSHead
> staging: vt6655: Join some lines of code to avoid code lines ending in
> (
>
> drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
> 1 file changed, 22 insertions(+), 26 deletions(-)
>
Patch failed at 0001 staging: vt6655: change the function name
s_vFillRTSHead
WARNING: line length of 138 exceeds 100 columns
#58: FILE: drivers/staging/vt6655/rxtx.c:915:
+ fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
bDisCRC, psEthHeader, wCurrentRate, byFBOption);
WARNING: line length of 138 exceeds 100 columns
#67: FILE: drivers/staging/vt6655/rxtx.c:934:
+ fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
bDisCRC, psEthHeader, wCurrentRate, byFBOption);
WARNING: line length of 138 exceeds 100 columns
#76: FILE: drivers/staging/vt6655/rxtx.c:948:
+ fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
bDisCRC, psEthHeader, wCurrentRate, byFBOption);
May be you need to consider to break this lines.
Bye Philipp
next prev parent reply other threads:[~2022-11-01 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 18:17 [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c Tanjuate Brunostar
2022-11-01 18:17 ` [PATCH v3 1/2] staging: vt6655: change the function name s_vFillRTSHead Tanjuate Brunostar
2022-11-01 18:17 ` [PATCH v3 2/2] staging: vt6655: Join some lines of code to avoid code lines ending in ( Tanjuate Brunostar
2022-11-01 22:15 ` Philipp Hortmann [this message]
2022-11-02 7:19 ` [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c Greg KH
2022-11-02 7:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67a1a02-addf-3197-e423-7c66ab97f6df@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox