From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754881AbcGEKTo (ORCPT ); Tue, 5 Jul 2016 06:19:44 -0400 Received: from zencphosting06.zen.co.uk ([82.71.204.9]:50784 "EHLO zencphosting06.zen.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbcGEKTm (ORCPT ); Tue, 5 Jul 2016 06:19:42 -0400 Subject: Re: [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data To: Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <1466813946-15940-1-git-send-email-aduggan@synaptics.com> Cc: Dmitry Torokhov , Linus Walleij , Jiri Kosina , Benjamin Tissoires , Vincent Huang From: Nick Dyer Message-ID: Date: Tue, 5 Jul 2016 11:19:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466813946-15940-1-git-send-email-aduggan@synaptics.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - zencphosting06.zen.co.uk X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - itdev.co.uk X-Get-Message-Sender-Via: zencphosting06.zen.co.uk: authenticated_id: nick.dyer@itdev.co.uk X-Authenticated-Sender: zencphosting06.zen.co.uk: nick.dyer@itdev.co.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2016 01:19, Andrew Duggan wrote: > The pointer to struct rmi_function in f12_data is never set and was never > used. The fn pointer is also stored in rmi_2d_sensor which is a member of > f12_data. > > Signed-off-by: Andrew Duggan Reviewed-by: Nick Dyer > --- > drivers/input/rmi4/rmi_f12.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c > index 041a91d..7d66766 100644 > --- a/drivers/input/rmi4/rmi_f12.c > +++ b/drivers/input/rmi4/rmi_f12.c > @@ -27,7 +27,6 @@ enum rmi_f12_object_type { > }; > > struct f12_data { > - struct rmi_function *fn; > struct rmi_2d_sensor sensor; > struct rmi_2d_sensor_platform_data sensor_pdata; > bool has_dribble; >