Re: [PATCH v2] platform: finally disallow IRQ0 in platform_get_irq() and its ilk

[Sergey Shtylyov <s.shtylyov@omp.ru>]

Hello!

On 3/11/22 10:35 PM, Sergey Shtylyov wrote:

> The commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is
> invalid") only calls WARN() when IRQ0 is about to be returned, however
> using IRQ0 is considered invalid (according to Linus) outside the arch/
> code where it's used by the i8253 drivers. Many driver subsystems treat
> 0 specially (e.g. as an indication of the polling mode by libata), so
> the users of platform_get_irq[_byname]() in them would have to filter
> out IRQ0 explicitly and this (quite obviously) doesn't scale...
> Let's finally get this straight and return -EINVAL instead of IRQ0!
> 
> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Acked-by: Marc Zyngier <maz@kernel.org>
> 
> ---
> The patch is against the 'driver-core-next' branch of Greg Kroah-Hartman's
> 'driver-core.git' repo.
> 
> Changes in version 2:
> - added Marc's ACK.

   Greg, are you going to finally merge this?

MBR, Sergey