From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935929AbcJFVlu (ORCPT ); Thu, 6 Oct 2016 17:41:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35540 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933011AbcJFVlm (ORCPT ); Thu, 6 Oct 2016 17:41:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 128B561832 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" To: Al Viro References: <1475789429-11414-1-git-send-email-okaya@codeaurora.org> <20161006213734.GM19539@ZenIV.linux.org.uk> Cc: timur@codeaurora.org, cov@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: Date: Thu, 6 Oct 2016 17:41:34 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161006213734.GM19539@ZenIV.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/2016 5:37 PM, Al Viro wrote: > On Thu, Oct 06, 2016 at 05:30:29PM -0400, Sinan Kaya wrote: >> This reverts commit acc29fb8f792 ("debugfs: ->d_parent is never NULL or >> negative") as it breaks the debugfs_remove_recursive API as show in the >> callstack below. > > NAK. Fix your code, don't break global asserts. > I can fix the code if you tell me what the problem is: http://lxr.free-electrons.com/ident?i=hidma_debug_uninit http://lxr.free-electrons.com/ident?i=hidma_debug_init The code didn't change between these commits. git log --oneline fs/debugfs/inode.c [doesn't work] 23f8a05 Merge branches 'work.misc', 'work.iget', 'work.const-qstr', 'work.splice_read' and 'current_time', remote-tracking branches 'ovl/misc' and 'ovl/ c2050a4 fs: Replace current_fs_time() with current_time() e0e0be8 libfs: support RENAME_NOREPLACE in simple_rename() acc29fb debugfs: ->d_parent is never NULL or negative 5614e77 Merge 4.6-rc4 into driver-core-next 87243de debugfs: Make automount point inodes permanently empty c646880 debugfs: add support for self-protecting attribute file fops [works] dde78b1 Revert "debugfs: ->d_parent is never NULL or negative" 23f8a05 Merge branches 'work.misc', 'work.iget', 'work.const-qstr', 'work.splice_read' and 'current_time', remote-tracking branches 'ovl/misc' and 'ovl/ c2050a4 fs: Replace current_fs_time() with current_time() e0e0be8 libfs: support RENAME_NOREPLACE in simple_rename() acc29fb debugfs: ->d_parent is never NULL or negative 5614e77 Merge 4.6-rc4 into driver-core-next -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.