From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbdLGIpC (ORCPT ); Thu, 7 Dec 2017 03:45:02 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:37680 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdLGIo7 (ORCPT ); Thu, 7 Dec 2017 03:44:59 -0500 X-Google-Smtp-Source: AGs4zMb0h3bf8ynn4kk9uuTfviKYxRs9JpCdfW+3ArnnzVJPN9Jeoz1A0tGfgl7kVxbrSug4tN38ZQ== Subject: Re: [PATCH v2 33/35] clocksource/drivers/atcpit100: Add andestech atcpit100 timer To: Greentime Hu , greentime@andestech.com, linux-kernel@vger.kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org, netdev@vger.kernel.org, deanbo422@gmail.com, devicetree@vger.kernel.org, viro@zeniv.linux.org.uk, dhowells@redhat.com, will.deacon@arm.com, linux-serial@vger.kernel.org Cc: Rick Chen References: <672e0b3843953d1ab69bc19baf1a0f217ec1b1fa.1511785528.git.green.hu@gmail.com> From: Daniel Lezcano Message-ID: Date: Thu, 7 Dec 2017 09:44:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <672e0b3843953d1ab69bc19baf1a0f217ec1b1fa.1511785528.git.green.hu@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2017 13:28, Greentime Hu wrote: > From: Rick Chen > > ATCPIT100 is often used on the Andes architecture, > This timer provide 4 PIT channels. Each PIT channel is a > multi-function timer, can be configured as 32,16,8 bit timers > or PWM as well. > > For system timer it will set channel 1 32-bit timer0 as clock > source and count downwards until underflow and restart again. > > It also set channel 0 32-bit timer0 as clock event and count > downwards until condition match. It will generate an interrupt > for handling periodically. > > Signed-off-by: Rick Chen > Signed-off-by: Greentime Hu > --- Looks good. Please resend this patch folded with the Makefile change and the DT binding (fixed) as suggested by Arnd. I will merge them. Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog