From: Jens Axboe <axboe@kernel.dk>
To: Li Lingfeng <lilingfeng@huaweicloud.com>,
allison.karlitskaya@redhat.com, hch@infradead.org,
yukuai1@huaweicloud.com
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
houtao1@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH] block: Move checking GENHD_FL_NO_PART to bdev_add_partition()
Date: Thu, 18 Jan 2024 08:20:31 -0700 [thread overview]
Message-ID: <f6e687cc-debd-4864-901a-fb35be9f2adc@kernel.dk> (raw)
In-Reply-To: <20240118130401.792757-1-lilingfeng@huaweicloud.com>
On 1/18/24 6:04 AM, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@huawei.com>
>
> Commit 1a721de8489f ("block: don't add or resize partition on the disk
> with GENHD_FL_NO_PART") prevented all operations about partitions on disks
> with GENHD_FL_NO_PART in blkpg_do_ioctl() since they are meaningless.
> However, it changed error code in some scenarios. So move checking
> GENHD_FL_NO_PART to bdev_add_partition() to eliminate impact.
This looks fine, but it's identical to the one sent out by Yu two days
ago. Hmm? Who's the proper author?
Adding Yu.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-18 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 13:04 [PATCH] block: Move checking GENHD_FL_NO_PART to bdev_add_partition() Li Lingfeng
2024-01-18 15:20 ` Jens Axboe [this message]
2024-01-19 1:27 ` Yu Kuai
2024-01-20 1:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6e687cc-debd-4864-901a-fb35be9f2adc@kernel.dk \
--to=axboe@kernel.dk \
--cc=allison.karlitskaya@redhat.com \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox