public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: cgel.zte@gmail.com, linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	ye xingchen <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH linux-next] soc: mediatek:fix the compile warning which about svs_resume() and svs_suspend() When the static function are not be used,there gonna be a WARNNING for it. Ignore these will make the compile to sucess and should not effect any other thing.
Date: Fri, 22 Jul 2022 12:56:16 +0200	[thread overview]
Message-ID: <f6edd39f-3bca-d412-1140-e0a5b05200e4@gmail.com> (raw)
In-Reply-To: <20220722054609.1501177-1-ye.xingchen@zte.com.cn>

Hi Ye Xingchen,

On 22/07/2022 07:46, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Reported-by: Zeal Robot<ye.xingchen@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks for your patch. Unfortunately that got already fixed in my tree with this 
patch:
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.19-next/soc&id=c749d676a33d99ee4c40d69ac2bf280270d890ad

Regards,
Matthias

> ---
>   drivers/soc/mediatek/mtk-svs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index dee8664a12fd..f411fcda8c6d 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1478,7 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
>   	return 0;
>   }
>   
> -static int svs_suspend(struct device *dev)
> +__maybe_unused static int svs_suspend(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
>   	struct svs_bank *svsb;
> @@ -1512,7 +1512,7 @@ static int svs_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int svs_resume(struct device *dev)
> +__maybe_unused static int svs_resume(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
>   	int ret;

      reply	other threads:[~2022-07-22 10:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22  5:46 [PATCH linux-next] soc: mediatek:fix the compile warning which about svs_resume() and svs_suspend() When the static function are not be used,there gonna be a WARNNING for it. Ignore these will make the compile to sucess and should not effect any other thing cgel.zte
2022-07-22 10:56 ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6edd39f-3bca-d412-1140-e0a5b05200e4@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=cgel.zte@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=ye.xingchen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox