[PATCH linux-next] soc: mediatek:fix the compile warning which about svs_resume() and svs_suspend() When the static function are not be used,there gonna be a WARNNING for it. Ignore these will make the compile to sucess and should not effect any other thing.

[PATCH linux-next] soc: mediatek:fix the compile warning which about svs_resume() and svs_suspend() When the static function are not be used,there gonna be a WARNNING for it. Ignore these will make the compile to sucess and should not effect any other thing.

[cgel.zte]

From: ye xingchen <ye.xingchen@zte.com.cn>

Reported-by: Zeal Robot<ye.xingchen@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/soc/mediatek/mtk-svs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index dee8664a12fd..f411fcda8c6d 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1478,7 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
 	return 0;
 }
 
-static int svs_suspend(struct device *dev)
+__maybe_unused static int svs_suspend(struct device *dev)
 {
 	struct svs_platform *svsp = dev_get_drvdata(dev);
 	struct svs_bank *svsb;
@@ -1512,7 +1512,7 @@ static int svs_suspend(struct device *dev)
 	return 0;
 }
 
-static int svs_resume(struct device *dev)
+__maybe_unused static int svs_resume(struct device *dev)
 {
 	struct svs_platform *svsp = dev_get_drvdata(dev);
 	int ret;
-- 
2.25.1

Re: [PATCH linux-next] soc: mediatek:fix the compile warning which about svs_resume() and svs_suspend() When the static function are not be used,there gonna be a WARNNING for it. Ignore these will make the compile to sucess and should not effect any other thing.

[Matthias Brugger]

Hi Ye Xingchen,

On 22/07/2022 07:46, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Reported-by: Zeal Robot<ye.xingchen@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Thanks for your patch. Unfortunately that got already fixed in my tree with this 
patch:
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.19-next/soc&id=c749d676a33d99ee4c40d69ac2bf280270d890ad

Regards,
Matthias

> ---
>   drivers/soc/mediatek/mtk-svs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index dee8664a12fd..f411fcda8c6d 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1478,7 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
>   	return 0;
>   }
>   
> -static int svs_suspend(struct device *dev)
> +__maybe_unused static int svs_suspend(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
>   	struct svs_bank *svsb;
> @@ -1512,7 +1512,7 @@ static int svs_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int svs_resume(struct device *dev)
> +__maybe_unused static int svs_resume(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
>   	int ret;