From: Markus Elfring <Markus.Elfring@web.de>
To: Chuhong Yuan <hslester96@gmail.com>, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] media: go7007: fix a miss of snd_card_free
Date: Fri, 6 Dec 2019 15:10:52 +0100 [thread overview]
Message-ID: <f6fcd441-e92d-0fff-e488-9507999b1682@web.de> (raw)
In-Reply-To: <20191206120735.21873-1-hslester96@gmail.com>
> go7007_snd_init() misses a snd_card_free() in an error path.
> Add the missed call to fix it.
How do you think about to take another look also at the previous update suggestion
“[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()”?
https://lore.kernel.org/linux-media/05efac78-3a14-803c-5b4a-68670728628b@users.sourceforge.net/
https://lore.kernel.org/patchwork/patch/831887/
https://lkml.org/lkml/2017/9/19/115
Regards,
Markus
next prev parent reply other threads:[~2019-12-06 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 12:07 [PATCH] media: go7007: fix a miss of snd_card_free Chuhong Yuan
2019-12-06 14:10 ` Markus Elfring [this message]
2019-12-06 14:37 ` Chuhong Yuan
2019-12-06 17:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6fcd441-e92d-0fff-e488-9507999b1682@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=hslester96@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox