Re: [PATCH v5 1/4] rust: pci: provide access to PCI Class and Class-related items

[John Hubbard <jhubbard@nvidia.com>]

On 8/21/25 3:51 AM, Danilo Krummrich wrote:
> On Thu Aug 21, 2025 at 6:42 AM CEST, John Hubbard wrote:
>> Allow callers to write Class::STORAGE_SCSI instead of
>> bindings::PCI_CLASS_STORAGE_SCSI, for example.
>>
>> New APIs:
>>      Class::STORAGE_SCSI, Class::NETWORK_ETHERNET, etc.
>>      Class::as_raw()
>>      Class: From<u32> for Class
>>      ClassMask: Full, ClassSubclass
>>      Device::pci_class()
>>
>> Cc: Danilo Krummrich <dakr@kernel.org>
>> Cc: Alexandre Courbot <acourbot@nvidia.com>
>> Cc: Elle Rhumsaa <elle@weathered-steel.dev>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>>   rust/kernel/pci.rs    |  10 ++
>>   rust/kernel/pci/id.rs | 239 ++++++++++++++++++++++++++++++++++++++++++
> 
> Please add rust/kernel/pci/ to the maintainers entry.

OK.

> 
> (Would have done on apply, but I have another comment on patch 3.)
> 
>>   2 files changed, 249 insertions(+)
>>   create mode 100644 rust/kernel/pci/id.rs

thanks,
-- 
John Hubbard