From: "Nuno Sá" <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Lucas Stankus <lucas.p.stankus@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Puranjay Mohan <puranjay@kernel.org>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
kernel@pengutronix.de,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
Marius Cristea <marius.cristea@microchip.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] iio: simplify with spi_get_device_match_data()
Date: Fri, 07 Jun 2024 10:55:44 +0200 [thread overview]
Message-ID: <f7196ddf96551114204f7e8ba17b409fd3493202.camel@gmail.com> (raw)
In-Reply-To: <20240606-spi-match-data-v1-0-320b291ee1fe@linaro.org>
On Thu, 2024-06-06 at 16:26 +0200, Krzysztof Kozlowski wrote:
> Not tested on hardware, but code looks equivalent and should not have
> functional effect.
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (8):
> iio: accel: adxl313: simplify with spi_get_device_match_data()
> iio: accel: adxl355: simplify with spi_get_device_match_data()
> iio: adc: max11205: simplify with spi_get_device_match_data()
> iio: adc: ti-ads131e08: simplify with spi_get_device_match_data()
> iio: adc: ti-tsc2046: simplify with spi_get_device_match_data()
> iio: addac: ad74413r: simplify with spi_get_device_match_data()
> iio: dac: max5522: simplify with spi_get_device_match_data()
> iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data()
>
> drivers/iio/accel/adxl313_spi.c | 8 +-------
> drivers/iio/accel/adxl355_spi.c | 10 +++-------
> drivers/iio/adc/max11205.c | 5 +----
> drivers/iio/adc/mcp3564.c | 6 ------
> drivers/iio/adc/ti-ads131e08.c | 4 +---
> drivers/iio/adc/ti-tsc2046.c | 7 +------
> drivers/iio/addac/ad74413r.c | 13 +++----------
> drivers/iio/dac/max5522.c | 11 +++--------
> 8 files changed, 13 insertions(+), 51 deletions(-)
> ---
LGTM, just some minor comments/asks that don't really stop me from:
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
next prev parent reply other threads:[~2024-06-07 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 14:26 [PATCH 0/8] iio: simplify with spi_get_device_match_data() Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 1/8] iio: accel: adxl313: " Krzysztof Kozlowski
2024-06-07 8:57 ` Nuno Sá
2024-06-07 9:18 ` Krzysztof Kozlowski
2024-06-08 17:22 ` Jonathan Cameron
2024-06-06 14:26 ` [PATCH 2/8] iio: accel: adxl355: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 3/8] iio: adc: max11205: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 4/8] iio: adc: ti-ads131e08: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 5/8] iio: adc: ti-tsc2046: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 6/8] iio: addac: ad74413r: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 7/8] iio: dac: max5522: " Krzysztof Kozlowski
2024-06-06 14:26 ` [PATCH 8/8] iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data() Krzysztof Kozlowski
2024-06-07 8:55 ` Nuno Sá [this message]
2024-06-08 17:25 ` [PATCH 0/8] iio: simplify with spi_get_device_match_data() Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7196ddf96551114204f7e8ba17b409fd3493202.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=o.rempel@pengutronix.de \
--cc=puranjay@kernel.org \
--cc=ramona.bolboaca@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox