From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959FBC6FD19 for ; Mon, 13 Mar 2023 01:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbjCMBX4 (ORCPT ); Sun, 12 Mar 2023 21:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbjCMBXy (ORCPT ); Sun, 12 Mar 2023 21:23:54 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC6D234010; Sun, 12 Mar 2023 18:23:47 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VdeV5bi_1678670624; Received: from 30.97.48.63(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VdeV5bi_1678670624) by smtp.aliyun-inc.com; Mon, 13 Mar 2023 09:23:45 +0800 Message-ID: Date: Mon, 13 Mar 2023 09:23:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] serial: sprd: Drop of_match_ptr for ID table To: Krzysztof Kozlowski , Greg Kroah-Hartman , Jiri Slaby , Orson Zhai , Chunyan Zhang , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230310222957.315848-1-krzysztof.kozlowski@linaro.org> <20230310222957.315848-2-krzysztof.kozlowski@linaro.org> From: Baolin Wang In-Reply-To: <20230310222957.315848-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/2023 6:29 AM, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). > > drivers/tty/serial/sprd_serial.c:1242:34: error: ‘serial_ids’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/tty/serial/sprd_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c > index 492a3bdab5ba..b58f51296ace 100644 > --- a/drivers/tty/serial/sprd_serial.c > +++ b/drivers/tty/serial/sprd_serial.c > @@ -1250,7 +1250,7 @@ static struct platform_driver sprd_platform_driver = { > .remove = sprd_remove, > .driver = { > .name = "sprd_serial", > - .of_match_table = of_match_ptr(serial_ids), > + .of_match_table = serial_ids, > .pm = &sprd_pm_ops, > }, > };