From: Stephen Boyd <sboyd@kernel.org>
To: Alessandro Carminati <alessandro.carminati@gmail.com>
Cc: Philip Daly <pdaly@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Sanitize possible_parent_show to Handle Return Value of of_clk_get_parent_name
Date: Tue, 12 Sep 2023 10:59:51 -0700 [thread overview]
Message-ID: <f72f0a599fa5ca03321454fd14dd8856.sboyd@kernel.org> (raw)
In-Reply-To: <CAPp5cGSbdhLb2c5hQrP-O-+j63haXs0c6=JCoFxnAzF1mhspuA@mail.gmail.com>
Quoting Alessandro Carminati (2023-09-12 10:05:19)
> Il giorno ven 8 set 2023 alle ore 23:25 Stephen Boyd
> <sboyd@kernel.org> ha scritto:
> >
> > Is nothing actually wrong? And this is a speculative patch?
>
> In the current state, Linux can crash, so I would say that there's something
> wrong.
> I submitted this patch in response to a specific bug report that caused a
> kernel crash during testing.
Where is the bug report? On some public tracker? Can you link to it?
>
> >
> > All other arms of this conditional statement check the validity of the
> > pointer before printing the string. And when the parent isn't known we
> > print "(missing)", so it looks like we should do that instead. How about
> > this patch?
>
> Indeed, your patch appears to provide a more verbose coding and accurate
> message, which is valuable for troubleshooting.
> So yeah, for what it is worth, I think it is good as well.
Cool, can you send it after testing it out?
next prev parent reply other threads:[~2023-09-12 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:48 [PATCH] Sanitize possible_parent_show to Handle Return Value of of_clk_get_parent_name Alessandro Carminati
2023-09-07 14:15 ` Alessandro Carminati
2023-09-07 22:33 ` Stephen Boyd
2023-09-08 8:36 ` Alessandro Carminati
2023-09-08 21:25 ` Stephen Boyd
2023-09-12 17:05 ` Alessandro Carminati
2023-09-12 17:59 ` Stephen Boyd [this message]
2023-09-14 13:25 ` Alessandro Carminati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f72f0a599fa5ca03321454fd14dd8856.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=alessandro.carminati@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdaly@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox