From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9042C433FE for ; Sat, 5 Dec 2020 16:01:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0BDF2332A for ; Sat, 5 Dec 2020 16:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727738AbgLEQAR (ORCPT ); Sat, 5 Dec 2020 11:00:17 -0500 Received: from mga01.intel.com ([192.55.52.88]:27984 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727347AbgLEP3O (ORCPT ); Sat, 5 Dec 2020 10:29:14 -0500 IronPort-SDR: CLjanD/QTRewvRikLdxG42ELpyXJjae2BrVHSVHqULuuKL4EO212pwFZPHds5z/OB2M5PDpPOC uJBPwrIEYstQ== X-IronPort-AV: E=McAfee;i="6000,8403,9825"; a="191774455" X-IronPort-AV: E=Sophos;i="5.78,395,1599548400"; d="scan'208";a="191774455" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2020 06:59:52 -0800 IronPort-SDR: +vl+HACmjCKcAtpEM37NXeuK0wfxYW7gV4L1SEvyX/90iJeWmUPkwGbEPU4HvxhF+3xikZUCgi GC/J6Jf/Vm+A== X-IronPort-AV: E=Sophos;i="5.78,395,1599548400"; d="scan'208";a="436104261" Received: from schamb2-mobl2.amr.corp.intel.com (HELO [10.212.89.161]) ([10.212.89.161]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2020 06:59:51 -0800 Subject: Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write To: Vinod Koul , Bard Liao Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com References: <20201202204645.23891-1-yung-chuan.liao@linux.intel.com> <20201202204645.23891-5-yung-chuan.liao@linux.intel.com> <20201205074554.GR8403@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: Date: Sat, 5 Dec 2020 08:43:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201205074554.GR8403@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> -static int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value) >> +int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value) >> { >> return sdw_nwrite_no_pm(slave, addr, 1, &value); >> } >> +EXPORT_SYMBOL(sdw_write_no_pm); > > Why not export this is patch 1..? yes, good point. I guess Bard and I were debugging in parallel and missed this. thanks for pointing it out.