From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B683CC43334 for ; Fri, 17 Jun 2022 19:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234913AbiFQTb6 (ORCPT ); Fri, 17 Jun 2022 15:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbiFQTb4 (ORCPT ); Fri, 17 Jun 2022 15:31:56 -0400 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E895D55498 for ; Fri, 17 Jun 2022 12:31:55 -0700 (PDT) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-1014b2752c1so6695095fac.11 for ; Fri, 17 Jun 2022 12:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EM4WuQB1JkdTQD8PY45ndgmJsVAA9Yd6J+wbPO6NpPg=; b=TcZ7SsxLlJOf8PjxVePN9jg050m+yfM+JWoqwMqqcRQognupSR97SauP4yE0s235yb ddqXUpJ2jmqQ2cPn0LYI/eUMXwGCnQYZGxq09p1VvIOFWOKnXPLd6CCuPMPvgPP+a5Of YbzaWxRWjHeubq5L+RnC2r7UE+g4xISk26HfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EM4WuQB1JkdTQD8PY45ndgmJsVAA9Yd6J+wbPO6NpPg=; b=Ncwq4p+iUG6DeX3Vp3bCovN2zrBIC8ROAjSnTgzHTE9zSKILiI/rwE7r0kGI27+cj7 cweQtrkqgNI4Fj3p2WUftxGUMuozXoJJnIs+fFjeBXpZHnzr6r7Ab6mpF+UKXxkC5WOa RqI2w/H63tDii8jDbpasQ2tmodu/PZffuYgYHniIZ3vpHRhIKmeua3FR0qWXFxuxSE4m pDLIa8DgHnnHbleY3RxNUbidoTX23TaJAZ5wXOobFURNe4mW6+NLYHdjtZTI/vO1vBPN ZKdnaT9LTboJznSlonpHLsyFGzrgLIaaklG7zOzfJM/K1yt/of0E8fBaPSl39CB7dILG 1DpA== X-Gm-Message-State: AJIora/ScRXSd+qRmI69Uw3o4LtVMN2aGp7krfOU00YdNnagOhTUCiXc 9zhd/9KcU8QIMzbXxQKYP7D+dg== X-Google-Smtp-Source: AGRyM1udGQRr7r3xRSI/SRpvnZ3d7wdlghukWbcfvBoS9d8ngIokzM5DUrYDRBl24rE/d98H+8gkjw== X-Received: by 2002:a05:6870:6097:b0:e1:a94d:9a38 with SMTP id t23-20020a056870609700b000e1a94d9a38mr6481520oae.191.1655494314848; Fri, 17 Jun 2022 12:31:54 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id w4-20020a9d3604000000b0060aeccf6b44sm2944399otb.41.2022.06.17.12.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 12:31:54 -0700 (PDT) Subject: Re: [PATCH V3] selftests/vm: Add protection_keys tests to run_vmtests To: Kalpana Shetty , akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220617111019.476-1-kalpana.shetty@amd.com> Cc: Shuah Khan From: Shuah Khan Message-ID: Date: Fri, 17 Jun 2022 13:31:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220617111019.476-1-kalpana.shetty@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/22 5:10 AM, Kalpana Shetty wrote: > Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests > from a single shell script. > > Signed-off-by: Kalpana Shetty > --- > Changes in V3: > Shuah Khan's review comments incorporated, added protection_keys binary check. > > tools/testing/selftests/vm/run_vmtests.sh | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index 41fce8bea929..b19c6b1b84c4 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -179,4 +179,15 @@ run_test ./ksm_tests -N -m 1 > # KSM test with 2 NUMA nodes and merge_across_nodes = 0 > run_test ./ksm_tests -N -m 0 > > +# protection_keys tests > +if ./protection_keys_32 &> /dev/null > +then > + run_test ./protection_keys_32 > +fi > + > +if ./protection_keys_64 &> /dev/null > +then > + run_test ./protection_keys_64 > +fi > + > exit $exitcode > Why not use file test operators. -x works for this case. There is no need to run attempt to run the test. thanks, -- Shuah