From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07DFF204C3B for ; Fri, 3 Jul 2026 19:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783108514; cv=none; b=qHsZcAhki8HhrJKLf74K7oaY1XZZAO+7imP8nIoYQK/FPA2eheWPTA4BicoJBLo/sbJndZBydmJQ2IMrZRp+ghQveujSpOfNDwbXeY+Zyy7wd3cYD14gwfFuw05tybSf8T39A9ILuEqe4mP8Ytg3/0p4dTCNj2B5vabzPeSzTf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783108514; c=relaxed/simple; bh=dqOHIAGMWhCgRowmL1u07fCxLEb4Pr3jh8BO4JUIoiI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ph5kBQJlBB9NUih9g9O/vmVTrT8HVRM1D91BM0EAJfDbeG1ExVmQuUk124QDpUoZShjzGsM+rNoyzqYK8hiv96SSEI83I3vjLSTISpqaTiG/ikKx9/mnFd6X//WYZHeiKtbTR5oN3Qfl9KJpU32Yw+9C4nOkpxaDjJbwL8YWt1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=eO2SeGoj; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="eO2SeGoj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783108511; bh=dqOHIAGMWhCgRowmL1u07fCxLEb4Pr3jh8BO4JUIoiI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eO2SeGojJ+r0vQNNXHIuPbEdgQ79bOPQ+EDjyOcfr/k15Tqldg9z173ziGZ8AFx57 0GF75+tgDQbkTObZz/WHIqP008Ea9t8kYQD1e50bf00+Lo9/PEVdA1t/YeMacSj0tE vJOV3HDESBw7kxAdkUhupmzopq8Ecj/QwhEUQWheeZnTIv8Qv5skakKOAa1cZH5+rV Vu9dA3ebE2l5IpmG9v+a8ev1VttaF8E/Ddn0uqjCH4T7Dwxj48gUNAsOC7dI+TMzOF 8TWdt4wA936pZ/7z2l5Apw2j+u/++L/hyB0f8jvnYEHP+zdK7iz2Fds5cEIXKbPtT+ GerjIbsFkYB5A== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 650DA17E063B; Fri, 3 Jul 2026 21:55:10 +0200 (CEST) Message-ID: Date: Fri, 3 Jul 2026 22:55:09 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 03/39] drm/display: bridge_connector: Pass HDMI capabilities through caps struct To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Daniel Stone , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20260702-dw-hdmi-qp-scramb-v8-0-d79890d00b6a@collabora.com> <20260702-dw-hdmi-qp-scramb-v8-3-d79890d00b6a@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/3/26 5:19 PM, Dmitry Baryshkov wrote: > On Thu, Jul 02, 2026 at 05:46:16PM +0300, Cristian Ciocaltea wrote: >> Switch drm_bridge_connector_init() to >> drmm_connector_hdmi_init_with_caps(), collecting the bridge's HDMI >> properties into a stack drm_connector_hdmi_caps so future HDMI 2.x >> capabilities can be plumbed without growing the argument list. >> >> Introduce struct drm_bridge::supported_hdmi_ver to let bridges declare >> the HDMI specification version they are conformant with, and forward it >> to the connector layer through the new caps struct so HDMI 2.x features >> can be gated on real source capability rather than guesswork. > > And it's left uninitialized by the bridges, which doesn't mean anything. > If you don't want to touch all bridge drivers in one commit, please > provide some migration path and hopefully get rid of it by the end of > the series. Sure, one question though: at the end of the migration, would it be fine to stick with drmm_connector_hdmi_init_with_caps() and just drop drmm_connector_hdmi_init()? Otherwise I'll rename it back. > At least, there should be a drm_warn() if the version in > unsspecified. I’ll double-check if any use cases remain that can't be covered by this series. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/display/drm_bridge_connector.c | 29 ++++++++++++++------------ >> include/drm/drm_bridge.h | 6 ++++++ >> 2 files changed, 22 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c >> index 92f8a2d7aab4..796069dbf1a1 100644 >> --- a/drivers/gpu/drm/display/drm_bridge_connector.c >> +++ b/drivers/gpu/drm/display/drm_bridge_connector.c >> @@ -823,8 +823,10 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, >> struct drm_connector *connector; >> struct i2c_adapter *ddc = NULL; >> struct drm_bridge *panel_bridge __free(drm_bridge_put) = NULL; >> - unsigned int supported_formats = BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444); >> - unsigned int max_bpc = 8; >> + struct drm_connector_hdmi_caps caps = { >> + .supported_formats = BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444), >> + .max_bpc = 8, >> + }; > > I'm really not sure that we need separate caps. But if we do, it would > make sense to embed it as is in the drm_bridge instead of having the > scattered fields. Ack. > >> bool support_hdcp = false; >> int connector_type; >> int ret; >> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h >> index 18f3db367dc1..2d8b5e4c64ba 100644 >> --- a/include/drm/drm_bridge.h >> +++ b/include/drm/drm_bridge.h >> @@ -1176,6 +1176,12 @@ struct drm_bridge { >> */ >> const char *product; >> >> + /** >> + * @supported_hdmi_ver: HDMI version the bridge is conformant with. >> + * This is only relevant if @DRM_BRIDGE_OP_HDMI is set. >> + */ >> + enum hdmi_version supported_hdmi_ver; >> + >> /** >> * @supported_formats: Bitmask of @drm_output_color_format listing >> * supported output formats. This is only relevant if >> >> -- >> 2.54.0 >> >