From: Jijie Shao <shaojijie@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>,
<wojciech.drewek@intel.com>
Cc: <shaojijie@huawei.com>, <shenjian15@huawei.com>,
<wangjie125@huawei.com>, <liuyonglong@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net 1/2] net: hns: fix wrong head when modify the tx feature when sending packets
Date: Wed, 6 Dec 2023 20:31:43 +0800 [thread overview]
Message-ID: <f7588e40-0fea-4350-89fe-c432eacb68f7@huawei.com> (raw)
In-Reply-To: <ffd7a4cbefa8c4f435db5bab0f5f7f2d4e2dad73.camel@redhat.com>
on 2023/12/6 19:18, Paolo Abeni wrote:
> + priv->ops.fill_desc = fill_desc_v2;
> + priv->ops.maybe_stop_tx = hns_nic_maybe_stop_tx_v2;
> Side note: since both 'fill_desc' and 'maybe_stop_tx' have constant
> values, for net-next you should really consider replacing the function
> pointers with direct-calls.
>
> You currently have at least 2 indirect calls per wire packet, which
> hurt performances a lot in case security issues mitigations are in
> place.
>
> Cheers,
>
> Paolo
Thank you for your advice. Currently, because the hardware behavior is
different, the two versions of ops are retained to unify the subsequent
process. We will try to unify the two version ops, and if that does not
work, we will consider maintaining the status quo. Thanks again! Jijie
next prev parent reply other threads:[~2023-12-06 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:32 [PATCH V3 net 0/2] There are some bugfix for the HNS ethernet driver Jijie Shao
2023-12-04 14:32 ` [PATCH V3 net 1/2] net: hns: fix wrong head when modify the tx feature when sending packets Jijie Shao
2023-12-06 11:18 ` Paolo Abeni
2023-12-06 12:31 ` Jijie Shao [this message]
2023-12-06 14:27 ` Paolo Abeni
2023-12-04 14:32 ` [PATCH V3 net 2/2] net: hns: fix fake link up on xge port Jijie Shao
2023-12-05 11:44 ` Wojciech Drewek
2023-12-06 11:30 ` [PATCH V3 net 0/2] There are some bugfix for the HNS ethernet driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7588e40-0fea-4350-89fe-c432eacb68f7@huawei.com \
--to=shaojijie@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wojciech.drewek@intel.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox