From: Carlos Bilbao <carlos.bilbao@amd.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: corbet@lwn.net, ojeda@kernel.org, jani.nikula@linux.intel.com,
rdunlap@infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, konstantin@linuxfoundation.org,
Akira Yokosawa <akiyks@gmail.com>,
rust-for-linux <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v7 1/2] docs: Move rustdoc output, cross-reference it
Date: Tue, 18 Jul 2023 08:49:55 -0500 [thread overview]
Message-ID: <f75bb80a-e49c-24e5-c897-7c4ecc804f84@amd.com> (raw)
In-Reply-To: <CANiq72k+uB4Px=_kGNEiduc0AewC05XO2zTqC3+ABa0hcxui9w@mail.gmail.com>
On 7/17/23 11:37, Miguel Ojeda wrote:
> On Mon, Jul 17, 2023 at 5:16 PM Carlos Bilbao <carlos.bilbao@amd.com> wrote:
>>
>> +# Where to place rustdoc generated documentation
>> +RUSTDOC_OUTPUT = $(objtree)/Documentation/output/rust/rustdoc
>
> I think we may be able to get away with just `:=` instead of `=`.
Yes, for v8 we can simply use `:=`.
>
> Also, I assume this is intended to be overridable by the user, right?
> i.e. that is why you wrote the identifier as uppercase.
That's true, I don't see any reason to make this uppercase.
>
> In addition, I thought about basing it on `BUILDDIR` from the Doc's
> `Makefile`, but that probably needs moving that one so that we can
> access it here (in the case where we are not building as part of
> `htmldocs`), and thus maybe it is not worth it.
>
> (Cc'ing the rust-for-linux list, by the way)
Thanks for CC'ing, I should have done it.
>
> Cheers,
> Miguel
Thanks,
Carlos
next prev parent reply other threads:[~2023-07-18 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 15:16 [PATCH v7 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2023-07-17 15:16 ` [PATCH v7 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2023-07-17 16:37 ` Miguel Ojeda
2023-07-18 13:49 ` Carlos Bilbao [this message]
2023-07-18 15:24 ` Miguel Ojeda
2023-07-17 15:16 ` [PATCH v7 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2023-07-17 16:39 ` Miguel Ojeda
2023-07-18 13:54 ` Carlos Bilbao
2023-07-18 15:32 ` Miguel Ojeda
2023-07-17 16:29 ` [PATCH v7 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f75bb80a-e49c-24e5-c897-7c4ecc804f84@amd.com \
--to=carlos.bilbao@amd.com \
--cc=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox