RE: [PATCH v7 7/9] iommu/vt-d: Allow qi_submit_sync() to return the QI faults

Tian, Kevin
2023-12-26T04:14:00Z

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Tuesday, December 26, 2023 12:03 PM
>
> On 2023/12/22 12:23, Tian, Kevin wrote:
> >> From: Liu, Yi L <yi.l.liu@intel.com>
> >> Sent: Thursday, December 21, 2023 11:40 PM
> >>
> >> + fault &= DMA_FSTS_IQE | DMA_FSTS_ITE | DMA_FSTS_ICE;
> >> + if (fault) {
> >> + if (fsts)
> >> + *fsts |= fault;
> >
> > do we expect the fault to be accumulated? otherwise it's clearer to
> > just do direct assignment instead of asking for the caller to clear
> > the variable before invocation.
>
> not quite get. do you mean the fault should not be cleared in the caller
> side?
>

I meant:

if (fsts)
*fsts = fault;

unless there is a reason to *OR* the original value.