RE: [PATCH v7 7/9] iommu/vt-d: Allow qi_submit_sync() to return the QI faults

Tian, Kevin
2023-12-22T04:23:29Z

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 21, 2023 11:40 PM
>
> + fault &= DMA_FSTS_IQE | DMA_FSTS_ITE | DMA_FSTS_ICE;
> + if (fault) {
> + if (fsts)
> + *fsts |= fault;

do we expect the fault to be accumulated? otherwise it's clearer to
just do direct assignment instead of asking for the caller to clear
the variable before invocation.

the rest looks good:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>