From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32035C433F5 for ; Thu, 17 Mar 2022 14:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235413AbiCQOuH (ORCPT ); Thu, 17 Mar 2022 10:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235403AbiCQOuE (ORCPT ); Thu, 17 Mar 2022 10:50:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A230BC6244; Thu, 17 Mar 2022 07:48:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1DE06618E3; Thu, 17 Mar 2022 14:48:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05A49C340E9; Thu, 17 Mar 2022 14:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647528526; bh=eSx/h17S9s0irOtmnOXZ/7IILNo/qKjLl5f/FVn+xtE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iHo+dxIdxNgJpuIc8Knho0CUGjHwXH+k4bLlwEpqNqqj80QpQSDYcVo6uHO58qxVO 9ZnBFuSgHSmcYOfEX4WB90Tlk1+Nk4y3//xo5z0qriVqb7fUAF1Y1+XVqAg6XpxOmj zxJzHd7HJCOrhXZeRgsSU8Mmk0zMvLcheJelO8KXFAeJYMiFnv+KGSU4E/97evO/DX vrws0WY+K6Bn5XMYgysN4gxvHb/PVL/j0FMqRAXN0cLPHPr2ldW4B/NgG/AsvCDVv7 Wu+eRy0x+gGBWJtyQl/bbqqLUSyxC97kGLBb1Rq4aNPqIWom9iyUuXeHhQxrU1Hrnx XvaglhmaAVw1Q== Message-ID: Date: Thu, 17 Mar 2022 08:48:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol Content-Language: en-US To: Jakub Kicinski Cc: menglong8.dong@gmail.com, pabeni@redhat.com, rostedt@goodmis.org, mingo@redhat.com, xeb@mail.ru, davem@davemloft.net, yoshfuji@linux-ipv6.org, imagedong@tencent.com, edumazet@google.com, kafai@fb.com, talalahmad@google.com, keescook@chromium.org, alobakin@pm.me, flyingpeng@tencent.com, mengensun@tencent.com, dongli.zhang@oracle.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, benbjiang@tencent.com References: <20220316063148.700769-1-imagedong@tencent.com> <20220316063148.700769-4-imagedong@tencent.com> <20220316201853.0734280f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <4315b50e-9077-cc4b-010b-b38a2fbb7168@kernel.org> <20220316210534.06b6cfe0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: David Ahern In-Reply-To: <20220316210534.06b6cfe0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/16/22 10:05 PM, Jakub Kicinski wrote: > On Wed, 16 Mar 2022 21:35:47 -0600 David Ahern wrote: >> On 3/16/22 9:18 PM, Jakub Kicinski wrote: >>> >>> I guess this set raises the follow up question to Dave if adding >>> drop reasons to places with MIB exception stats means improving >>> the granularity or one MIB stat == one reason? >> >> There are a few examples where multiple MIB stats are bumped on a drop, >> but the reason code should always be set based on first failure. Did you >> mean something else with your question? > > I meant whether we want to differentiate between TYPE, and BROADCAST or > whatever other possible invalid protocol cases we can get here or just > dump them all into a single protocol error code. I think a single one is a good starting point.