public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
	Jeff Johnson <jjohnson@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Anand Moon <linux.amoon@gmail.com>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Subject: [PATCH net-next] wifi: ath12k: Omit a variable reassignment in ath12k_ahb_configure_rproc()
Date: Mon, 20 Oct 2025 16:21:29 +0200	[thread overview]
Message-ID: <f7c1a504-a449-4497-baf2-dcd69486a3fe@web.de> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 20 Oct 2025 16:16:34 +0200

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/wireless/ath/ath12k/ahb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index b30527c402f6..92079de201a2 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -876,8 +876,7 @@ static int ath12k_ahb_configure_rproc(struct ath12k_base *ab)
 
 	ret = ath12k_ahb_register_rproc_notifier(ab);
 	if (ret < 0) {
-		ret = dev_err_probe(&ab->pdev->dev, ret,
-				    "failed to register rproc notifier\n");
+		dev_err_probe(&ab->pdev->dev, ret, "failed to register rproc notifier\n");
 		goto err_put_rproc;
 	}
 
-- 
2.51.1


                 reply	other threads:[~2025-10-20 14:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7c1a504-a449-4497-baf2-dcd69486a3fe@web.de \
    --to=markus.elfring@web.de \
    --cc=ath12k@lists.infradead.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jjohnson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox