From: "Rafał Miłecki" <zajec5@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] perf report: Skip symbols for idle symbols
Date: Tue, 18 Oct 2022 14:54:07 +0200 [thread overview]
Message-ID: <f7e79f3a-be97-334b-84f2-76da0981e991@gmail.com> (raw)
In-Reply-To: <20220608055146.1446-1-zajec5@gmail.com>
On 8.06.2022 07:51, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Displaying idle symbols is rather useless and makes reviewing "real"
> symbols harder. perf top already skips them so perf report should
> probably do the same.
>
> BEFORE
>
> # Overhead Command Shared Object Symbol
> # ........ ............... ..................... ...................................
> #
> 75.04% swapper [kernel.kallsyms] [k] arch_cpu_idle
> 1.05% ksoftirqd/0 [kernel.kallsyms] [k] __pi___inval_dcache_area
> 0.78% ksoftirqd/0 [kernel.kallsyms] [k] __netif_receive_skb_core
> 0.75% ksoftirqd/0 [kernel.kallsyms] [k] fib_table_lookup
> 0.58% ksoftirqd/0 [kernel.kallsyms] [k] __dev_queue_xmit
> 0.56% ksoftirqd/0 [kernel.kallsyms] [k] bcm4908_enet_start_xmit
> 0.55% ksoftirqd/0 [kernel.kallsyms] [k] __skb_flow_dissect
> 0.53% ksoftirqd/0 [kernel.kallsyms] [k] __pi___clean_dcache_area_poc
>
> AFTER
>
> # Overhead Command Shared Object Symbol
> # ........ ............... ..................... ...................................
> #
> 4.21% ksoftirqd/0 [kernel.kallsyms] [k] __pi___inval_dcache_area
> 3.13% ksoftirqd/0 [kernel.kallsyms] [k] __netif_receive_skb_core
> 3.01% ksoftirqd/0 [kernel.kallsyms] [k] fib_table_lookup
> 2.32% ksoftirqd/0 [kernel.kallsyms] [k] __dev_queue_xmit
> 2.23% ksoftirqd/0 [kernel.kallsyms] [k] bcm4908_enet_start_xmit
> 2.21% ksoftirqd/0 [kernel.kallsyms] [k] __skb_flow_dissect
> 2.13% ksoftirqd/0 [kernel.kallsyms] [k] __pi___clean_dcache_area_poc
> 2.00% ksoftirqd/0 [kernel.kallsyms] [k] eth_type_trans
> 1.86% ksoftirqd/0 [kernel.kallsyms] [k] bcm4908_enet_poll_rx
> 1.73% ksoftirqd/0 [kernel.kallsyms] [k] __local_bh_enable_ip
> 1.63% ksoftirqd/0 [kernel.kallsyms] [k] fib_rules_lookup
> 1.61% ksoftirqd/0 [kernel.kallsyms] [k] bcm4908_enet_poll_tx
> (...)
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Ping? Does it look OK to you?
next prev parent reply other threads:[~2022-10-18 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 5:51 [PATCH] perf report: Skip symbols for idle symbols Rafał Miłecki
2022-10-18 12:54 ` Rafał Miłecki [this message]
2022-10-18 19:18 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7e79f3a-be97-334b-84f2-76da0981e991@gmail.com \
--to=zajec5@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox