From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Ethan Carter Edwards <ethan@ethancedwards.com>
Cc: Kalle Valo <kvalo@kernel.org>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
Jeff Johnson <jjohnson@kernel.org>,
Harshitha Prem <quic_hprem@quicinc.com>,
Kalle Valo <quic_kvalo@quicinc.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath12k@lists.infradead.org" <ath12k@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: Fix uninitialized variable and remove goto
Date: Wed, 12 Feb 2025 09:05:34 -0800 [thread overview]
Message-ID: <f7f9d508-e999-4e5c-b02f-976e7cb700f3@oss.qualcomm.com> (raw)
In-Reply-To: <94ddba7eff9f4261bf8fa547f1ba4d7d@realtek.com>
On 2/10/2025 8:09 PM, Ping-Ke Shih wrote:
>>>>
>>>> Addresses-Coverity-ID: 1642337 ("Uninitialized scalar variable")
>>>
>>> Is that an official kernel tag? IMO the proper tag would be
>> So, it isn't "official" as far as I can tell, but it is widely used in
>> other commits, especially by Gustavo Silva.
>>
>> Also:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=778e2478d19574508861bcb
>> 1806d6e34d095587c
>>
>> Coverity-IDs: is another option I have found. I have seen Closes: a few
>> times as well. I'm not really sure what the best option is, honestly.
>
> In my patch, I used and treated Addresses-Coverity-ID as a unofficial tag,
> so additional empty line is added.
>
> Days ago I have received Coverity issues sent to mailing list, so I used
> Closes tag at that time. But recently I have not seen that kind of mails.
> Instead, I visit Coverity web site to check issues and use
> Addresses-Coverity-ID tag, since Coverity link is not visible to everyone.
> That is just my thought.
The problem I have is that I get Coverity fixes both from the linux and the
linux-next projects:
https://scan.coverity.com/projects/linux?tab=overview
https://scan.coverity.com/projects/linux-next-weekly-scan?tab=overview
The Coverity IDs from these projects are allocated independently, so a
Coverity ID does not uniquely identify an issue.
The URL uniquely identifies an issue, and also utilizes an official tag.
That is my thought.
/jeff
next prev parent reply other threads:[~2025-02-12 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 4:36 [PATCH] wifi: ath12k: Fix uninitialized variable and remove goto Ethan Carter Edwards
2025-02-11 1:08 ` Jeff Johnson
2025-02-11 2:28 ` Ethan Carter Edwards
2025-02-11 4:09 ` Ping-Ke Shih
2025-02-12 17:05 ` Jeff Johnson [this message]
2025-02-13 0:37 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f9d508-e999-4e5c-b02f-976e7cb700f3@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=ethan@ethancedwards.com \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=quic_hprem@quicinc.com \
--cc=quic_kvalo@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox