From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9449DC10F14 for ; Tue, 8 Oct 2019 08:28:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70D07206B6 for ; Tue, 8 Oct 2019 08:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730379AbfJHI2t (ORCPT ); Tue, 8 Oct 2019 04:28:49 -0400 Received: from smtprelay0234.hostedemail.com ([216.40.44.234]:57236 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728104AbfJHI2t (ORCPT ); Tue, 8 Oct 2019 04:28:49 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 378B918028EB1; Tue, 8 Oct 2019 08:28:48 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cord46_2f84ddd429022 X-Filterd-Recvd-Size: 3536 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Tue, 8 Oct 2019 08:28:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH][next] crypto: inside-secure: fix spelling mistake "algorithmn" -> "algorithm" From: Joe Perches To: Pascal Van Leeuwen , Colin King , Antoine Tenart , Herbert Xu , "David S . Miller" , "linux-crypto@vger.kernel.org" Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 08 Oct 2019 01:28:45 -0700 In-Reply-To: References: <20191008081410.18857-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-10-08 at 08:15 +0000, Pascal Van Leeuwen wrote: > > There is a spelling mistake in a dev_err message. Fix it. [] > > diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside- [] > > @@ -437,7 +437,7 @@ static int safexcel_aead_setkey(struct crypto_aead *ctfm, const u8 *key, > > goto badkey; > > break; > > default: > > - dev_err(priv->dev, "aead: unsupported hash algorithmn"); > > + dev_err(priv->dev, "aead: unsupported hash algorithm"); > > goto badkey; > > } [] > Actually, the typing error is well spotted, but the fix is not correct. > What actually happened here is that a \ got accidentally deleted, > there should have been a "\n" at the end of the line ... Other missing newlines in the same file: --- drivers/crypto/inside-secure/safexcel_cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-secure/safexcel_cipher.c index cecc56073337..47fec8a0a4e1 100644 --- a/drivers/crypto/inside-secure/safexcel_cipher.c +++ b/drivers/crypto/inside-secure/safexcel_cipher.c @@ -695,21 +695,21 @@ static int safexcel_send_req(struct crypto_async_request *base, int ring, sreq->nr_dst = sreq->nr_src; if (unlikely((totlen_src || totlen_dst) && (sreq->nr_src <= 0))) { - dev_err(priv->dev, "In-place buffer not large enough (need %d bytes)!", + dev_err(priv->dev, "In-place buffer not large enough (need %d bytes)!\n", max(totlen_src, totlen_dst)); return -EINVAL; } dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRECTIONAL); } else { if (unlikely(totlen_src && (sreq->nr_src <= 0))) { - dev_err(priv->dev, "Source buffer not large enough (need %d bytes)!", + dev_err(priv->dev, "Source buffer not large enough (need %d bytes)!\n", totlen_src); return -EINVAL; } dma_map_sg(priv->dev, src, sreq->nr_src, DMA_TO_DEVICE); if (unlikely(totlen_dst && (sreq->nr_dst <= 0))) { - dev_err(priv->dev, "Dest buffer not large enough (need %d bytes)!", + dev_err(priv->dev, "Dest buffer not large enough (need %d bytes)!\n", totlen_dst); dma_unmap_sg(priv->dev, src, sreq->nr_src, DMA_TO_DEVICE);