From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E60C2F6577 for ; Mon, 4 May 2026 20:24:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777926284; cv=none; b=jcM3is7tgsBuH2sr8hM5ZVUQ+U3qTAhibWaj2ZZUPQOawVhhtZ7vu8PKnaUTbAOiC8C7DWUsLWppYZfSzLtHooSFy35ZmbYiWYPRx998bhLM0CB1yhK4kQVR2EDzF0iAFVkMf3Iju0kgKs8Yqh8QqgVTiTo0txhHh83qLVezvRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777926284; c=relaxed/simple; bh=zOav8ZaMYbNbj6qwrovxDSOR8ggG40qxMC3t7Ts9gW0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EjsMjJwSugFEsTWXY1c+8Q574IppF34dqt+Pcf6B4peHmU61WFKZijmzQOzxRvFGdkKjtJrgBygzym7YpD5fxKQtfQK5e79knHxRhDnrMWagFxLSDf2jp2+oVhcNcUB5ZEVMlewJg1XnEbXqIuaQjaLAnnWy4MzDg20L76gFB1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QiO58DQN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QiO58DQN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777926281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QeDkXbPaUg0Eyt+G1glq5ihHly+Yq7goyY5wJc9DJbk=; b=QiO58DQN88MayH07tykgCkiYTR3hkY4LCCUs9rk66+CWEOiX1Tku8d/fDdW1SYul73Ina5 rS2F5IOFCFfIhO5OYogXT5fr9Uf/Axeyzm6DdZyRsmEujci+DDkNhIcpO9wD5YQNVErSY8 ozCAdx+Y69vLMOQArTvMn7AxtbCEqCA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-KDKkanG2O7yw5l9qCc4jRA-1; Mon, 04 May 2026 16:24:38 -0400 X-MC-Unique: KDKkanG2O7yw5l9qCc4jRA-1 X-Mimecast-MFC-AGG-ID: KDKkanG2O7yw5l9qCc4jRA_1777926277 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B316B1956088; Mon, 4 May 2026 20:24:36 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.64.157]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D1D781800480; Mon, 4 May 2026 20:24:32 +0000 (UTC) From: Aaron Conole To: Ilya Maximets Cc: netdev@vger.kernel.org, Eelco Chaudron , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Yuan Tan , Yang Yang , dev@openvswitch.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net v2 0/2] openvswitch: fix self-deadlock on release of tunnel vports In-Reply-To: (Ilya Maximets's message of "Mon, 4 May 2026 13:43:53 +0200") References: <20260430233848.440994-1-i.maximets@ovn.org> Date: Mon, 04 May 2026 16:24:30 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Ilya Maximets writes: > On 5/1/26 1:38 AM, Ilya Maximets wrote: >> Two patches - the fix for the actual bug and the selftest that reproduces it. >> >> I missed the self-deadlock in the original patch that introduced the issue, >> because testing required code modification in the ovs-vswitchd to force it to >> use legacy tunnel ports. I thought I made the change correctly, but apparently >> something went wrong and the tests were run with the standard LWT infra instead. >> The selftest added in this patch set will at least prevent this kind of mistakes >> in the future. >> >> I mentioned, however, that these tunnel vports are legacy and not actually used >> by ovs-vswitchd. RTM_NEWLINK + COLLECT_METADATA is used in conjunction with the >> standard OVS_VPORT_TYPE_NETDEV instead since 2017. The code to use the legacy >> tunnels still exists in ovs-vswitchd however, but only as a fallback for older >> kernels and we're planning to remove it in the next release. I'll be sending an >> RFC to remove support for these legacy tunnel types from the kernel, as they >> serve no real purpose today and only increase the uAPI surface for CVEs, but >> we need to fix the known bugs for stable versions. >> >> >> Version 2: >> - Added Ack from Eelco to the first patch (not to the second as it >> changed a little). >> - Removed now unused import socket in the dpctl.py [pylint/ruff]. >> >> - Regarding comments from both Sashiko instances on the selftest patch: >> >> * The background process is not waited for / not killed. >> If it hangs it will not be killable anyway, so it's not a problem. > > Both sashiko instances still flag this. Looks like the cover letter is not > included in the prompt. > > If someone thinks I should add the suggested kill on exit, I can, but it will > not be effective in case the process hangs. One option is to put a comment in the test itself documenting this kind of behavior. At least, then the model might not flag it. I don't feel strongly about that, however. > Best regards, Ilya Maximets.