From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11DE3F54B9 for ; Wed, 6 May 2026 15:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778081774; cv=none; b=UgWjTroFCQPD/IopnIsrzfJxJ3vYGJOQLv3oSODRp/MqsoK0vKsgXMS0N7wgLqhDkUDK7lsS6K7OMRTn1zvWwMUH2BxIO+RYRIq0Y6JSrZh/16kPH/ETnqd34AENSbjWfLJ1bvDIVH/ZAUag9gfOeMjAlDCXsOEgZSIuuWZ7X34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778081774; c=relaxed/simple; bh=CwP7g+L7tmTM1gOICXchU65OK9ZzlG0f6YkTuUwv3XI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=qyujKDtQmzLRWy8KFlcastb2ejHpYyu1o5Oy2czfLslRlma61mevZNABylX1p+01V7U5q+QxX3ckgRgbedJkXz7SA1lnfjKUIUmPkD1IugHYZFdVWBamYEhkNkAcaKdJWJm1TWyX7pnRG/6NzlIyfol+cjPmwIebVZyoW6yy0js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dxkGciZB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dxkGciZB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778081770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P0UoDCQban7BwMooeGuUu7b8/86Tvw53i5NmMB+ICeI=; b=dxkGciZBFOLkdoYszCtG7/yCO2sznZrtI8x9u4P2AVeZSaPAlSyWiBzlh3NjTNcmr46WgR FL8Av7hF8jLSBMsUjVRXv6pWKTF0jkgZT2cTt/0SSEmK8LjfcX8FqVkkLhDgMTJOzPta0u Hp5TbO1suAbwll8fVyxsTgNeGdoUHh0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-Oj-mcXI6Mm21pizt2v4p5w-1; Wed, 06 May 2026 11:36:06 -0400 X-MC-Unique: Oj-mcXI6Mm21pizt2v4p5w-1 X-Mimecast-MFC-AGG-ID: Oj-mcXI6Mm21pizt2v4p5w_1778081765 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3E9419560B4; Wed, 6 May 2026 15:36:04 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.65.142]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 32CC318001CE; Wed, 6 May 2026 15:36:02 +0000 (UTC) From: Aaron Conole To: Minxi Hou Cc: netdev@vger.kernel.org, echaudro@redhat.com, i.maximets@ovn.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 2/2] selftests: openvswitch: add pop_vlan test In-Reply-To: <20260505124957.1239812-3-houminxi@gmail.com> (Minxi Hou's message of "Tue, 5 May 2026 20:49:57 +0800") References: <20260505124957.1239812-1-houminxi@gmail.com> <20260505124957.1239812-3-houminxi@gmail.com> Date: Wed, 06 May 2026 11:36:00 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Minxi Hou writes: > Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action > correctly strips 802.1Q VLAN tags from frames. > > Test structure: > - Baseline: untagged forwarding validates basic connectivity. > - Negative: forward without pop_vlan, tagged frame is invisible > to ns2 (no VLAN sub-interface), ping fails. > - Positive: pop_vlan strips tag on forward path, push_vlan > restores tag on return path, ping succeeds. > > Use static ARP entries to avoid VLAN-tagged ARP complexity. > Rely on ping success/failure for verification =E2=80=94 no tcpdump or > pcap files needed. > > Signed-off-by: Minxi Hou > --- Thanks for adding this. I'm still a little unclear about the explicit modprobe for 8021q. Is it really needed? I thought the request to add a vlan tagged interface should auto-load that module (unless it is blacklisted or something). I guess this is an attempt to short-circuit the skip, but maybe it would be better to configure an interface and if that fails, then either fail the test or skip the test.