From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59963176236 for ; Tue, 25 Jun 2024 15:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719328646; cv=none; b=uQNkN2M90v56LLHOCL94HVCtGRElS4ZxFqAfS/pEvtJPJLAEDsAiRbtiA/gR2jIC9z1Wt46XqRGv/stFRdz+CahJ5F2kXcBw63VQ/z7jNT3Uzmo+nN4AU75caEeUo7QE2TE4Hzt2mHK90qf6RCeZwXwFhWK18lNDkVSRIddlqGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719328646; c=relaxed/simple; bh=tX7m3fbagW+Xu7Gov5fW024aDM7tXtp/CEdtBqu2uo0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=qCtj0lQaed+tnjdHJMgl8IV8v6hSIxqfxee3eCktuukL7P6Aws3180tqNirsqq4JCVNoUXJxBZk9r/2cmJceGBwjveAPBGObsamsvkaCf4+ohqxKdsqd4BYyjUk32gLv2btllNQIUkyw5bba+D1yNH+kIwBPf9P9ihaPk+xqxis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QGO5mlWo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QGO5mlWo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719328644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W1pWUcsCbDz/QzTtn1KclW1Fnze6TwCApU6kqlWKFYE=; b=QGO5mlWo78Dd7lLnyg5BNYeyxbUr2Vcn1LDSPbIyDBjgWKiAZ98A18ErHpR3gVK7InMdoh /F542ob25HYIfvhCDhXDDKMkvcrwi6hu3fWO65lD4w9dADxIwM0x12QGIiglPwQpKmKTD1 +tp+WUDONm4rg0u3HWJhViSsndWoU8c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-gWiis1akMt6uaXVEmPltRA-1; Tue, 25 Jun 2024 11:17:20 -0400 X-MC-Unique: gWiis1akMt6uaXVEmPltRA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2B8EA19560B2; Tue, 25 Jun 2024 15:17:18 +0000 (UTC) Received: from RHTRH0061144 (dhcp-17-72.bos.redhat.com [10.18.17.72]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9C30E1954AC1; Tue, 25 Jun 2024 15:17:15 +0000 (UTC) From: Aaron Conole To: Jakub Kicinski Cc: Paolo Abeni , netdev@vger.kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Pravin B Shelar , "David S. Miller" , Eric Dumazet , Shuah Khan , Stefano Brivio , =?utf-8?Q?Adri=C3=A1n?= Moreno , Simon Horman Subject: Re: [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script. In-Reply-To: <20240625074145.69fc9d9f@kernel.org> (Jakub Kicinski's message of "Tue, 25 Jun 2024 07:41:45 -0700") References: <20240620125601.15755-1-aconole@redhat.com> <20240621180126.3c40d245@kernel.org> <20240625070654.6a00efef@kernel.org> <20240625074145.69fc9d9f@kernel.org> Date: Tue, 25 Jun 2024 11:17:14 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Jakub Kicinski writes: > On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote: >> > Sorry for not checking it earlier, looks like the runner was missing >> > pyroute: >> > >> > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py >> > Need to install the python pyroute2 package >=3D 0.6. >> > >> > I guess run_cmd counter-productively eats the stderr output ? :(=20=20 >>=20 >> Awesome :) I will add a patch to ovs-dpctl that will turn the >> sys.exit(0) into sys.exit(1) - that way it should do the skip. >>=20 >> When I previously tested, I put an error in the `try` without reading >> the except being specifically for a ModuleNotFound error. >>=20 >> I'll make sure pyroute2 isn't installed when I run it again. >>=20 >> Thanks for your help Jakub and Paolo! > > BTW I popped the v2 back into the queue, so the next run (in 20min) > will tell us if that's the only thing we were missing =F0=9F=A4=9E=EF=B8= =8F :) I'll wait to post the v3 then. So far, the only change I have is: --- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py +++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py @@ -34,7 +34,7 @@ try: =20 except ModuleNotFoundError: print("Need to install the python pyroute2 package >=3D 0.6.") - sys.exit(0) + sys.exit(1) =20 =20 OVS_DATAPATH_FAMILY =3D "ovs_datapath" ---