From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A8F737647E for ; Fri, 8 May 2026 14:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778251054; cv=none; b=H26dDwBNIU61ZeE5LmIgGQubZuTsUP0tF0+z3iM9ZfF+CEsWAKRNJWwN9quds/d0sFWkElRAqkVSGI5SPpKzUoK5K1GE9YecdpSuRlvDiTtpdRt6GsnvcUEmWAlIyRAFux3LIDVknshFsC19+yi29gO/21QTNF1gPimvMFTMj/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778251054; c=relaxed/simple; bh=Mbc6RyQAJ135g/HwpgFncUzGBqFAua5oLCLfqRuGKsw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=AuR07Cq3EXdHobXYcfGTuHes0/tFnvBywgD28xMDI0hy7VBmivlY4MEy6drXZhx3t/TuMw/QJTSYZDn2iuzOFAOwmgc1U1mLJ5uBuo37JDAquRPBXSJCIKK1oKjiJPmSfs2azb+NsGN5Y+62CkLgS0xITnXKFHY0dsOfdYpz5X0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iuSv6TJj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iuSv6TJj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778251052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yVkKNgHxig7M46X9NYBxZb338TZpmf1fuqe4XUbcFJw=; b=iuSv6TJjvcfTnWpyY3ZTKEHolkkMmanvOzsjumx7hvIy/fDrr3PSohgLWbY4dqBy4yybD2 uY8vZoPJ5H9kKwCIKO11RTKIZc3QLd0BZgliu3XDLHaco7cl8Ydifg9oKWgRhUaWLTmFZp frmierHy5op7Jmc+2JeNLgzlhqUhBKo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-jBZh-RDlMV-Cj9rTjJjAVw-1; Fri, 08 May 2026 10:37:27 -0400 X-MC-Unique: jBZh-RDlMV-Cj9rTjJjAVw-1 X-Mimecast-MFC-AGG-ID: jBZh-RDlMV-Cj9rTjJjAVw_1778251046 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF8711956094; Fri, 8 May 2026 14:37:25 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.65.142]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5DB411803A8E; Fri, 8 May 2026 14:37:23 +0000 (UTC) From: Aaron Conole To: Minxi Hou Cc: netdev@vger.kernel.org, echaudro@redhat.com, i.maximets@ovn.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v8 2/2] selftests: openvswitch: add pop_vlan test In-Reply-To: <20260508134308.2857449-3-houminxi@gmail.com> (Minxi Hou's message of "Fri, 8 May 2026 21:43:08 +0800") References: <20260508134308.2857449-1-houminxi@gmail.com> <20260508134308.2857449-3-houminxi@gmail.com> Date: Fri, 08 May 2026 10:37:21 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Minxi Hou writes: > Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action > correctly strips 802.1Q VLAN tags from frames. > > Test structure: > - Baseline: untagged forwarding validates basic connectivity. > - Negative: forward without pop_vlan, tagged frame is invisible > to ns2 (no VLAN sub-interface), ping fails. > - Positive: pop_vlan strips tag on forward path, push_vlan > restores tag on return path, ping succeeds. > > Use static ARP entries to avoid VLAN-tagged ARP complexity. > Rely on ping success/failure for verification -- no tcpdump or > pcap files needed. > > Signed-off-by: Minxi Hou > --- There is an issue applying to net-next, so this will need to be rebased on net-next - likely a conflict from 05416ada37aa4 ("selftests: openvswitch: add tests for tunnel vport refcounting"). Please wait 24h before reposting and you can include my review tags in 1/2 and 2/2 Reviewed-by: Aaron Conole