From: Chris Wilson <chris@chris-wilson.co.uk>
To: Akshay Joshi <me@akshayjoshi.com>,
Keith Packard <keithp@keithp.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Akshay Joshi <me@akshayjoshi.com>
Subject: Re: [PATCH] Drivers: i915: Fix all space related issues.
Date: Tue, 16 Aug 2011 21:03:58 +0100 [thread overview]
Message-ID: <f80fcd$183avu@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1313523255-13629-1-git-send-email-me@akshayjoshi.com>
On Tue, 16 Aug 2011 15:34:10 -0400, Akshay Joshi <me@akshayjoshi.com> wrote:
> Various issues involved with the space character were generating
> warnings in the checkpatch.pl file. This patch removes most of those
> warnings.
> @@ -622,7 +622,7 @@
>
> #define ILK_DISPLAY_CHICKEN1 0x42000
> #define ILK_FBCQ_DIS (1<<22)
> -#define ILK_PABSTRETCH_DIS (1<<21)
> +#define ILK_PABSTRETCH_DIS (1<<21)
The others are space indented so the replacement tab looks wrong.
And that was the oddity I could spot in the patch.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-08-16 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 19:34 [PATCH] Drivers: i915: Fix all space related issues Akshay Joshi
2011-08-16 20:03 ` Chris Wilson [this message]
2011-08-17 19:25 ` Akshay Joshi
2011-08-17 19:27 ` Akshay Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$183avu@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@akshayjoshi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox