From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/i915: fix if statement (bogus semi-colon)
Date: Fri, 28 Oct 2011 18:20:20 +0100 [thread overview]
Message-ID: <f80fcd$2bbqtl@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <yund3dh9h4t.fsf@aiko.keithp.com>
On Fri, 28 Oct 2011 10:10:26 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Fri, 28 Oct 2011 14:42:41 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > - if (needs_idle_maps());
> > + if (needs_idle_maps())
>
> how embarrassing is that?
Actually it served an ulterior purpose and by exercising the workaround
showed us that it contained a more subtle bug. I believe therefore Ben
did it deliberately ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-10-28 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 11:42 [patch] drm/i915: fix if statement (bogus semi-colon) Dan Carpenter
2011-10-28 17:10 ` Keith Packard
2011-10-28 17:20 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$2bbqtl@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=keithp@keithp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).