From: <Rengarajan.S@microchip.com>
To: <jirislaby@kernel.org>, <linux-serial@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <UNGLinuxDriver@microchip.com>,
<Kumaravel.Thiagarajan@microchip.com>,
<linux-kernel@vger.kernel.org>,
<Tharunkumar.Pasumarthi@microchip.com>
Subject: Re: [PATCH v2 tty-next] 8250: microchip: pci1xxxx: Add PCIe Hot reset disable support for Rev C0 and later devices
Date: Fri, 25 Apr 2025 13:38:36 +0000 [thread overview]
Message-ID: <f843a0060c1ca54c563f828a03f1dd56293715ea.camel@microchip.com> (raw)
In-Reply-To: <bf5c1f39-149e-4bb4-9c07-a38ce5a99341@kernel.org>
Hi Jiri,
Thanks for reviewing the patch.
On Thu, 2025-04-24 at 10:44 +0200, Jiri Slaby wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On 24. 04. 25, 5:59, Rengarajan S wrote:
> > Systems that issue PCIe hot reset requests during a suspend/resume
> > cycle cause PCI1XXXX device revisions prior to C0 to get its UART
> > configuration registers reset to hardware default values. This
> > results
> > in device inaccessibility and data transfer failures. Starting with
> > Revision C0, support was added in the device hardware (via the Hot
> > Reset Disable Bit) to allow resetting only the PCIe interface and
> > its
> > associated logic, but preserving the UART configuration during a
> > hot
> > reset. This patch enables the hot reset disable feature during
> > suspend/
> > resume for C0 and later revisions of the device.
> >
> > v2
> > Retained the original writel and simplified the hot reset condition
> > v1
> > Initial Commit.
>
> This should have been under the --- line below.
Sure will update in the next revision.
>
> > Signed-off-by: Rengarajan S <rengarajan.s@microchip.com>
>
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
>
> > ---
>
> vvvvv here
>
> > drivers/tty/serial/8250/8250_pci1xxxx.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
>
> thanks,
> --
> js
> suse labs
next prev parent reply other threads:[~2025-04-25 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 3:59 [PATCH v2 tty-next] 8250: microchip: pci1xxxx: Add PCIe Hot reset disable support for Rev C0 and later devices Rengarajan S
2025-04-24 8:44 ` Jiri Slaby
2025-04-25 13:38 ` Rengarajan.S [this message]
2025-04-25 11:45 ` Greg KH
2025-04-25 13:39 ` Rengarajan.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f843a0060c1ca54c563f828a03f1dd56293715ea.camel@microchip.com \
--to=rengarajan.s@microchip.com \
--cc=Kumaravel.Thiagarajan@microchip.com \
--cc=Tharunkumar.Pasumarthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox