From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: add missing MODULE_DESCRIPTION() macros
Date: Wed, 12 Jun 2024 07:07:36 +0200 [thread overview]
Message-ID: <f849b64f-eaf4-46ca-b4a0-039fd0f6f2e7@gmail.com> (raw)
In-Reply-To: <20240610-md-drivers-staging-rtl8192e-v1-1-b5d11ee98297@quicinc.com>
On 6/11/24 02:33, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/rtl8192e/rtllib.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/rtl8192e/rtllib_crypt_ccmp.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/rtl8192e/rtllib_crypt_tkip.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/rtl8192e/rtllib_crypt_wep.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 1 +
> drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 1 +
> drivers/staging/rtl8192e/rtllib_crypt_wep.c | 1 +
> drivers/staging/rtl8192e/rtllib_module.c | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index cbb8c8dbe9b0..da9e630b594c 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -407,4 +407,5 @@ static void __exit rtllib_crypto_ccmp_exit(void)
> module_init(rtllib_crypto_ccmp_init);
> module_exit(rtllib_crypto_ccmp_exit);
>
> +MODULE_DESCRIPTION("Support module for rtllib CCMP crypto");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
> index 0244b524a7d4..3969b6b916ed 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
> @@ -708,4 +708,5 @@ static void __exit rtllib_crypto_tkip_exit(void)
> module_init(rtllib_crypto_tkip_init);
> module_exit(rtllib_crypto_tkip_exit);
>
> +MODULE_DESCRIPTION("Support module for rtllib TKIP crypto");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_wep.c b/drivers/staging/rtl8192e/rtllib_crypt_wep.c
> index 21c2b7666d6f..eae75d122553 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_wep.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_wep.c
> @@ -238,4 +238,5 @@ static void __exit rtllib_crypto_wep_exit(void)
> module_init(rtllib_crypto_wep_init);
> module_exit(rtllib_crypto_wep_exit);
>
> +MODULE_DESCRIPTION("Support module for rtllib WEP crypto");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c
> index e7af4a25b0be..469a69726c16 100644
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -175,4 +175,5 @@ static void __exit rtllib_exit(void)
> module_init(rtllib_init);
> module_exit(rtllib_exit);
>
> +MODULE_DESCRIPTION("Support module for rtllib wireless devices");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240610-md-drivers-staging-rtl8192e-0935b6c4b336
>
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2024-06-12 5:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 0:33 [PATCH] staging: rtl8192e: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-12 5:07 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f849b64f-eaf4-46ca-b4a0-039fd0f6f2e7@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox