Re: [PATCH v3 ] iommu/vt-d: Fix panic after kexec -p for kdump

Joerg Roedel
2019-10-30T09:33:21Z

Hi John,

On Mon, Oct 21, 2019 at 09:48:10PM -0500, John Donnelly wrote:
> Fixes: 8af46c784ecfe ("iommu/vt-d: Implement is_attach_deferred iommu ops
> entry")
> Cc: stable@vger.kernel.org # v5.3+
>
> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>
>
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index c4e0e4a9ee9e..f83a9a302f8e 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -2783,7 +2783,7 @@ static int identity_mapping(struct device *dev)
> struct device_domain_info *info;
>
> info = dev->archdata.iommu;
> - if (info && info != DUMMY_DEVICE_DOMAIN_INFO)
> + if (info && info != DUMMY_DEVICE_DOMAIN_INFO && info !=
> DEFER_DEVICE_DOMAIN_INFO)
> return (info->domain == si_domain);
>
> return 0;

I applied your patch for v5.4, but it needed manual fixup because your
mailer screwed up the patch format by inserting line-breaks and
converting tabs to spaces.

Please consider to setup and use 'git send-email' for your next patches.
This will get it all right and makes life easier for maintainers that
want to apply your patches.

Thanks,

Joerg