From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C78F2DB7BD for ; Sun, 2 Aug 2026 14:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785682097; cv=none; b=hRhrTtkK1COP3yfZQHrsDYe1OFH/BYdpT7ZOzXD47DUFAoB3m/RSufp1J06whxpuhg520wKQxH3vauCET6lMStMg0XFj5kcO2lDmfeC4O+xMkoH1IUkCTHwOrh86Xk1VHcbyHdy+lWDoS9U/mvM7tqzAMmubaE55jAGMg96aQ7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785682097; c=relaxed/simple; bh=Kl/kK6ZYTzg68QYqfqbJ3KVkURCxY2rizcrZuYbmm3s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=My0O+KRdqK8mdlX7srZL3e+6fP1TsXn018X5y8g1c0IYHeBdM46MiaRNjJ+7TSmwCRhs5HZx/mvLyi5Umt9/1OXxjeVaBHBHqhtBfndEwwq5xW/qQcbQeiAqwBW9Ol9P68/81rgCgv9VKmKSWQArBV24ueLGpDxSoyyT2StWDts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=VPlc+6E+; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="VPlc+6E+" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-45133d2974fso1634662fac.1 for ; Sun, 02 Aug 2026 07:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785682094; x=1786286894; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5cS2ofFOue4M8XamUu04ihCfrUZX2sV7BxKpIDM4Wao=; b=VPlc+6E+3FsQ/M+lz4t7dSUK1qYhhyOzGsbpDPYqPECP4vXPw08/OBUkoGFwyHn4kE kU3RlfG9CRr+8ciVk8Ncaz71MoONNIOf6opXvUWIWejB8g1SqouycyekrxqzXzw7jzlA DzXZ8LZN/8kO8XwH1mbv/PBlfbyWRbHtruwxO8Ii49ZbUIg6BwEAzej8VHSxDZX0SNhK xnckLWHJMbsUq9k7nQwwMaXMdGOrqpctovb9JPd5BsSb1nqL4Gn1YM40PW1i7NF/jNU7 5rRyGO5foch4tWbnWbsLgVPFTEs/mFPhsIoN+ZgRwo3LBpV95+Za6iGGk7lfEa2o+pry jCmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785682094; x=1786286894; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5cS2ofFOue4M8XamUu04ihCfrUZX2sV7BxKpIDM4Wao=; b=KuSQ6w+ZBULzCwqNPVSg4NlzSRJ72ZQsTOrGSyfFttH0UTxYYYyeKdci9ihV7hQhH/ J6YZYU8bhmche0y+fTeLoyr+Y0Hsm46mJGP+XNyGHZQiZoTAYw/DFsdOJW+f9GRSSyUY aIgJANG4QZ/Ybouy7az2VqY6u/JU0ztC/yBufcTMY3t39RTN9ZbtAwrOlNX3gUbreorP f5bx0YIgGR5D8wgF7U87zhTHnK8JWtV04/nSRVvY06odvhOftEZHr37Cj835t2vVZwyr zEyMvhdhO7EJCsLtzF6G+5wJXfR/ZVrerPOW5ZIwscV5Hf4SQxA6hz2s+R2Ne2WH5A3Y aAdw== X-Forwarded-Encrypted: i=1; AHgh+RqrZlqQxm4v8jmSC+KRtP2xGSusT9LIL4KpFbOHm2Fy93yjcRAD8AdN/PqUcMM7B490cOmnPIQ0j1p20eI=@vger.kernel.org X-Gm-Message-State: AOJu0YzVuM7mnYU8wQrHWWxCSAzdZGdXMIQ5/u64ygdeM5tOjJ/7OW6Q OdAURHBU5ngZI5gpKrvGjRijZUNyBvpS4adyDQEpkPys1lrW1tFsNNiQv48m7ejuqlo= X-Gm-Gg: AR+sD100dyDsfMDmFEvFkivKmUay++DaJN2cyyG5MOl5im/XrjqgsjKFcjH1InIFN1T 0s1BNfBshVNqr3ioV50RJ8DixjIGbLOxAjdqoX3u1Zo2zg5mAII4IZSkDFrGwM7RrLYsv+iY2IF Eg/AvJrDTvmVXh4Tde6fpq3yb7KMLEd2iDgq4SFQOyaZqTmdIszk8hIZUhDcI2evqXe7KlYQfC0 9tVKJdLc7aB9vlonm3jL+BaWIP2aCIFDEu8dZE0anOEllJEadENH0OT2Lzak1w3vZZrmPwctQY5 mlxQCsqh/ffL3W/52kJaqNnIn5Ce/Agl0H1KjDCO4rzzzmHy0vYyXsezgxLhDeJdZhEcQQ4dcHk NEuiKYVWp79dvo7BIIaJ26lwMGC+3zBP7MM/4RjlfnIWNv4R0uQRuPLgK+NxDTKGu+DSjlYmhFQ MZ831mdoaxjOODgE/C0pAcVNoH4wABWTceJR+IgVp8YHNOKN6Pg1t+ngC89AcLwUYuxeukurmSr z0LlD9+cwm+6/6LXhm7OltvCmC2koON0XbG7PU= X-Received: by 2002:a05:6871:c91d:b0:448:768a:49ee with SMTP id 586e51a60fabf-45905dd7d52mr10874364fac.13.1785682094364; Sun, 02 Aug 2026 07:48:14 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:5487:2b6e:1057:d3d3? ([2600:8803:e7e4:500:5487:2b6e:1057:d3d3]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-458f6064843sm6446172fac.4.2026.08.02.07.48.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 07:48:13 -0700 (PDT) Message-ID: Date: Sun, 2 Aug 2026 09:48:11 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: humidity: htc100c: Fix checkpatch warn unnecessary else To: Adi Nata , jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, u.kleine-koenig@baylibre.com, mazziesaccount@gmail.com, bhelgaas@google.com, o-takashi@sakamocchi.jp, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linux.dev References: <20260802014417.15485-1-adinata.softwareengineer@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260802014417.15485-1-adinata.softwareengineer@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/26 8:44 PM, Adi Nata wrote: > Checkpatch warning: Making checkpatch happy is not a good reason for a change on it's own. It is only there for guidance. It is not a strict rule that has to be followed. I think this is a good change because it reduces duplication of the return statements and eliminates an unreachable break statement. So write the commit message with that reasoning and don't mention checkpatch. > > WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return > + return IIO_VAL_FRACTIONAL; > + } else { > > Signed-off-by: Adi Nata > --- > drivers/iio/humidity/hdc100x.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c > index bc452cc8fbcf..38903239fb9a 100644 > --- a/drivers/iio/humidity/hdc100x.c > +++ b/drivers/iio/humidity/hdc100x.c > @@ -229,13 +229,11 @@ static int hdc100x_read_raw(struct iio_dev *indio_dev, > if (chan->type == IIO_TEMP) { > *val = 165000; > *val2 = 65536; > - return IIO_VAL_FRACTIONAL; > } else { > *val = 100000; > *val2 = 65536; > - return IIO_VAL_FRACTIONAL; > } > - break; > + return IIO_VAL_FRACTIONAL; > case IIO_CHAN_INFO_OFFSET: > *val = -15887; > *val2 = 515151;