* [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free
@ 2024-04-27 4:50 R Sundar
2024-05-03 16:23 ` R Sundar
2024-06-24 9:54 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: R Sundar @ 2024-04-27 4:50 UTC (permalink / raw)
To: p.zabel, airlied, daniel
Cc: dri-devel, linux-kernel, skhan, javier.carrasco.cruz, R Sundar,
Julia Lawall
use the new cleanup magic to replace of_node_put() with
__free(device_node) marking to auto release when they get out of scope.
Suggested-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: R Sundar <prosunofficial@gmail.com>
---
drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3/ipu-pre.c
index aef984a43190..95830cf8fa3e 100644
--- a/drivers/gpu/ipu-v3/ipu-pre.c
+++ b/drivers/gpu/ipu-v3/ipu-pre.c
@@ -113,8 +113,8 @@ int ipu_pre_get_available_count(void)
struct ipu_pre *
ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
{
- struct device_node *pre_node = of_parse_phandle(dev->of_node,
- name, index);
+ struct device_node *pre_node __free(device_node) =
+ of_parse_phandle(dev->of_node, name, index);
struct ipu_pre *pre;
mutex_lock(&ipu_pre_list_mutex);
@@ -123,14 +123,11 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
mutex_unlock(&ipu_pre_list_mutex);
device_link_add(dev, pre->dev,
DL_FLAG_AUTOREMOVE_CONSUMER);
- of_node_put(pre_node);
return pre;
}
}
mutex_unlock(&ipu_pre_list_mutex);
- of_node_put(pre_node);
-
return NULL;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free
2024-04-27 4:50 [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free R Sundar
@ 2024-05-03 16:23 ` R Sundar
2024-06-24 9:54 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: R Sundar @ 2024-05-03 16:23 UTC (permalink / raw)
To: p.zabel, airlied, daniel
Cc: dri-devel, linux-kernel, skhan, javier.carrasco.cruz,
Julia Lawall
On 27/04/24 10:20, R Sundar wrote:
> use the new cleanup magic to replace of_node_put() with
> __free(device_node) marking to auto release when they get out of scope.
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: R Sundar <prosunofficial@gmail.com>
> ---
> drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3/ipu-pre.c
> index aef984a43190..95830cf8fa3e 100644
> --- a/drivers/gpu/ipu-v3/ipu-pre.c
> +++ b/drivers/gpu/ipu-v3/ipu-pre.c
> @@ -113,8 +113,8 @@ int ipu_pre_get_available_count(void)
> struct ipu_pre *
> ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
> {
> - struct device_node *pre_node = of_parse_phandle(dev->of_node,
> - name, index);
> + struct device_node *pre_node __free(device_node) =
> + of_parse_phandle(dev->of_node, name, index);
> struct ipu_pre *pre;
>
> mutex_lock(&ipu_pre_list_mutex);
> @@ -123,14 +123,11 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
> mutex_unlock(&ipu_pre_list_mutex);
> device_link_add(dev, pre->dev,
> DL_FLAG_AUTOREMOVE_CONSUMER);
> - of_node_put(pre_node);
> return pre;
> }
> }
> mutex_unlock(&ipu_pre_list_mutex);
>
> - of_node_put(pre_node);
> -
> return NULL;
> }
>
Hi,
Any feedback on this patch.
Thanks,
Sundar
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free
2024-04-27 4:50 [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free R Sundar
2024-05-03 16:23 ` R Sundar
@ 2024-06-24 9:54 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2024-06-24 9:54 UTC (permalink / raw)
To: R Sundar, airlied, daniel
Cc: dri-devel, linux-kernel, skhan, javier.carrasco.cruz,
Julia Lawall
On Sa, 2024-04-27 at 10:20 +0530, R Sundar wrote:
> use the new cleanup magic to replace of_node_put() with
> __free(device_node) marking to auto release when they get out of scope.
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: R Sundar <prosunofficial@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-24 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-27 4:50 [PATCH linux-next] gpu:ipu-v3:pre: replace of_node_put() with __free R Sundar
2024-05-03 16:23 ` R Sundar
2024-06-24 9:54 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox