From: Steffen Maier <maier@linux.vnet.ibm.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
linux-s390@vger.kernel.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] s390: zfcp: Remove unneeded linux/miscdevice.h include
Date: Tue, 7 Mar 2017 16:30:13 +0100 [thread overview]
Message-ID: <f8941f5e-bbb5-43bd-5997-40f274325864@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161215141824.3297-2-clabbe.montjoie@gmail.com>
Thanks, Corentin, queued for next zfcp feature submission to linux-scsi as:
"zfcp: Remove unneeded linux/miscdevice.h include"
In fact, this seems a minor missing code cleanup of the following older
"feature" which also dropped the only former use of a misc device in zfcp:
663e0890e31cb85f0cca5ac1faaee0d2d52880b5
("[SCSI] zfcp: remove access control tables interface")
b5dc3c4800cc5c2c0b3c93a97eb4c7afa0aae49a
("[SCSI] zfcp: remove access control tables interface (keep sysfs files)")
1b33ef23946adee4b7d9d6b16b7285ce61063451
("zfcp: remove access control tables interface (port leftovers)").
On 12/15/2016 03:18 PM, Corentin Labbe wrote:
> drivers/s390/scsi/zfcp_aux.c does not contain any miscdevice so the
> inclusion of linux/miscdevice.h is uncessary.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/s390/scsi/zfcp_aux.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
> index bcc8f3d..82ac331 100644
> --- a/drivers/s390/scsi/zfcp_aux.c
> +++ b/drivers/s390/scsi/zfcp_aux.c
> @@ -29,7 +29,6 @@
> #define KMSG_COMPONENT "zfcp"
> #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
>
> -#include <linux/miscdevice.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> #include <linux/module.h>
>
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2017-03-07 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 14:18 [PATCH 1/2] s390/zcore: Remove unneeded linux/miscdevice.h include Corentin Labbe
2016-12-15 14:18 ` [PATCH 2/2] s390: zfcp: " Corentin Labbe
2017-03-07 15:30 ` Steffen Maier [this message]
2016-12-16 11:09 ` [PATCH 1/2] s390/zcore: " Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8941f5e-bbb5-43bd-5997-40f274325864@linux.vnet.ibm.com \
--to=maier@linux.vnet.ibm.com \
--cc=clabbe.montjoie@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).