public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>, corbet@lwn.net
Cc: kstewart@linuxfoundation.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] docs: add system-state document to admin-guide
Date: Wed, 22 Mar 2023 08:37:30 -0600	[thread overview]
Message-ID: <f8a8890b-7a02-6824-b5aa-957008ebda53@linuxfoundation.org> (raw)
In-Reply-To: <ZBrKcwoFMAhmIn1f@debian.me>

On 3/22/23 03:29, Bagas Sanjaya wrote:
> On Tue, Mar 21, 2023 at 05:18:16PM -0600, Shuah Khan wrote:
>> +scripts/checksyscalls.sh can be used to check if current architecture is
>> +missing any function calls compared to i386.
> 
> i386 is the reference architecture for comparing syscalls, right?
> 

Correct. If you are askig about "function calls" wording, this is coming
right from the checksyscalls.sh

>> +This scripts parses Documentation/features to find the support status
>> +information. It can be used to validate the contents of the files under
>> +Documentation/features or simply list.::
> 
> "... to validate contents of Documentation/features files or simply list
> them::"
> 
>> +Let's do one last sanity check on the system to see if the following two
>> +command outputs match. If they don't examine your system closely. kernel
>> +rootkits install their own ps, find, etc. utilities to mask their activity.
>> +The outputs match on my system. Do they on yours?
>> +
>> +ps ax | wc -l
>> +ls -d /proc/* | grep [0-9]|wc -l
> 

Thanks for catching this.

> The shell snippet above should be in a code block for consistency
> with other snippets.
> 
>> +Linux kernel supports several hardening options to make system secure.
>> +kconfig-hardened-check tool sanity checks kernel configuration for
>> +security. You can checkout the latest::
> 
> "... If you don't have the tool handy, you can clone the repository::"

I can fix it to say "clone the latest"

> 
>> + * https://docs.kernel.org/trace/index.html
> 
> Shouldn't the last ref be internal link (Documentation/trace/index.rst)?
> 

This docs.kernel.org link intentional and it is better to this rendered
version.

thanks,
-- Shuah


      reply	other threads:[~2023-03-22 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 23:18 [PATCH] docs: add system-state document to admin-guide Shuah Khan
2023-03-22  9:29 ` Bagas Sanjaya
2023-03-22 14:37   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8a8890b-7a02-6824-b5aa-957008ebda53@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox